Page MenuHomePhabricator

Allow - as an access key
Closed, DeclinedPublicFeature

Description

(A TODO was added in rMW2f64d0087d3af3de12855cba0c1057309f1049d5 to allow - to be used as an access key, as part of [1] that todo comment was removed, filing a task so it doesn't get forgotten)

In general in mediawiki messages, setting a message to - disables it. But, in the case of access keys for links, that might not be desirable behavior - instead, - should be treated like any other character and support for use as an access key

[1] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/661693

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 changed the subtype of this task from "Task" to "Feature Request".
Jdlrobson added a subscriber: Jdlrobson.

What problem would this solve?

Tagging special pages given this touches Linker component.

@DannyS712: Could you please answer the last comment? Thanks in advance!

@DannyS712: Could you please answer the last comment? Thanks in advance!

Sorry, didn't see it

What problem would this solve?

Tagging special pages given this touches Linker component.

It would allow the - character to be used as an access key like any other behavior. The problem is that while for most messages it makes sense to have - disable them, for an access key this is counter intuitive because it means there is no way to use that character

but why is that particular access key essential, and why would adding support for it be worth the extra complexity in code? I would argue that "-" having any other effect than disabling could be confusing to users who would need to look up the code or documentation to understand.

but why is that particular access key essential, and why would adding support for it be worth the extra complexity in code? I would argue that "-" having any other effect than disabling could be confusing to users who would need to look up the code or documentation to understand.

Its not essential, and if its not worth the effort feel free to decline - I was just moving this from a "TODO" comment in the code to a task so that it could be better discussed

Change 704421 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Revise FIXME comment

https://gerrit.wikimedia.org/r/704421

Change 704421 merged by jenkins-bot:

[mediawiki/core@master] Revise FIXME comments relating to use of '-' character as an access key

https://gerrit.wikimedia.org/r/704421

Jdlrobson claimed this task.

Thanks for this conversation @DannyS712

DannyS712 changed the task status from Resolved to Declined.Jul 14 2021, 8:17 PM

Thanks for this conversation @DannyS712

No problem - switching to declined though because the decision was to replace the todo with an explanation that we don't allow - as an access key