Page MenuHomePhabricator

Page Forms: Initially-hidden tokens input doesn't show placeholder text
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce

Form Source:

{{{info|page name=Token placeholder error[option]> <unique number>}}}
{|class=wikitable
!Select an option
|{{{field|option|input type=radiobutton|values=A,B|default=A|mandatory|show on select=A=>optionA;B=>optionB}}}
|
<div id=optionA>The placeholder text is visible here, because the field is visible when the form opens:<br>{{{field|OptA|input type=tokens|values=one, two, three, four, five|placeholder=A multiple selections allowed.}}}</div>
<div id=optionB>The placeholder text is '''NOT''' visible here, because the field is '''NOT''' visible when the form opens:<br>{{{field|OptB|input type=tokens|values=uno, dos, tres, quatro, cinco|placeholder=B multiple selections allowed.}}}</div>
|}

What happens?:
Selecting "B" in the example form does not show placeholder text.

What should have happened instead?:
Selecting "B" in the example form should show the placeholder text of "B multiple selections allowed."

Software version:
5.2.1 (01a2363) 19:05, 28 April 2021

Related Objects

Event Timeline

@MarkAHershberger - could you complete the task title? It looks like it got chopped off.

MarkAHershberger renamed this task from PageForms: to PageForms: Token input doesn't show hidden placeholder text.Jun 2 2021, 7:38 PM
Yaron_Koren renamed this task from PageForms: Token input doesn't show hidden placeholder text to Page Forms: Initially-hidden tokens input doesn't show placeholder text.Jun 2 2021, 8:45 PM

Thanks; I modified the title slightly.

Change 984235 had a related patch set uploaded (by Techwizzie; author: Techwizzie):

[mediawiki/extensions/PageForms@master] Fix placeholder width issue in hidden tokens input

https://gerrit.wikimedia.org/r/984235

Change 984235 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Fix placeholder width issue in hidden tokens input

https://gerrit.wikimedia.org/r/984235

Yaron_Koren claimed this task.
Yaron_Koren added a subscriber: Techwizzie.

Fixed, I think! Thanks to @MarkAHershberger for the actual fix, and @Techwizzie for integrating it into the local Select2.