Deprecate the mediawiki.viewport library
Closed, ResolvedPublic
Actions

Description

After talking to @phuedx, now that IntersectionObserver is widely available in our grade A browsers, we recommend deprecating the mediawiki.viewport library.
Intersection/MutationObserver will be more performant than our existing approach in RelatedArticles and QuickSurveys.

We will update RelatedArticles and QuickSurveys as part of T262859 to use Intersection/MutationObserver . For browsers that don't support it we will not show related articles and will not log impressions for QuickSurveys, which is fine.

We will then deprecate this module in core.

TODO

Drop from MobileFrontend
Rewrite QuickSurveys to use MutationObserver
Rewrite RelatedArticles to use MutationObserver
Deprecate in core

Details

Subject	Repo	Branch	Lines +/-
mediawiki.viewport: Replace ambiguous "[1.37]" mark with words	mediawiki/core	master	+1 -1
resources: Deprecate the mediawiki.viewport library	mediawiki/core	master	+4 -0
Drop unused mediawiki.viewport dependency	mediawiki/extensions/MobileFrontend	master	+0 -1

Customize query in gerrit

Related Objects

Mentioned In: T284251: RelatedArticles should use IntersectionObserver rather than deprecated mediawiki.viewport module
T262859: isElementInViewport is unnecessarily slow on Firefox
Mentioned Here: T284251: RelatedArticles should use IntersectionObserver rather than deprecated mediawiki.viewport module
T262859: isElementInViewport is unnecessarily slow on Firefox

Event Timeline

Jdlrobson created this task.Jun 2 2021, 6:56 PM

Restricted Application added a project: Performance-Team. · View Herald TranscriptJun 2 2021, 6:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Jdlrobson added a project: RelatedArticles.Jun 2 2021, 6:56 PM

Change 697847 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Drop unused dependency

https://gerrit.wikimedia.org/r/697847

gerritbot added a project: Patch-For-Review.Jun 2 2021, 7:01 PM

Change 697848 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Deprecate the mediawiki.viewport library

https://gerrit.wikimedia.org/r/697848

The MobileFrontend usage is a leftover from when we updated lazy loading images codebase and can be removed.

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.Jun 2 2021, 8:22 PM

Change 697847 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Drop unused mediawiki.viewport dependency

https://gerrit.wikimedia.org/r/697847

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).Jun 3 2021, 1:00 AM

Jdlrobson updated the task description. (Show Details)Jun 3 2021, 1:16 AM

Change 697848 merged by jenkins-bot:

[mediawiki/core@master] resources: Deprecate the mediawiki.viewport library

https://gerrit.wikimedia.org/r/697848

Maintenance_bot removed a project: Patch-For-Review.Jun 3 2021, 7:11 PM

Jdlrobson updated the task description. (Show Details)Jun 3 2021, 7:22 PM

Jdlrobson removed a project: MobileFrontend.

Resolving this. QuickSurveys will be handled in T262859.
RelatedArticles will be handled in T284251

Change 699448 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] mediawiki.viewport: Replace ambiguous "[1.37]" mark with words

https://gerrit.wikimedia.org/r/699448

gerritbot added a project: Patch-For-Review.Jun 11 2021, 4:52 PM

Change 699448 merged by jenkins-bot: