Steps:
- Select Yes on mobile
- Go back to the previous suggestion
- Toggle Yes
The link inspector should not advance to the next suggestion. Same goes for toggling No.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | KStoller-WMF | T276517 [EPIC] Growth: "add a link" structured task 3.0 | |||
| Resolved | • mewoph | T284230 Add a link: de-selecting Yes/No should not auto-advance (mobile) |
Event Timeline
Comment Actions
@MMiller_WMF @RHo this should be pretty straightforward and also probably a source of frustration for mobile users who are expecting de-selection to do nothing, so I'd propose we put it in the current sprint.
Comment Actions
Change 701588 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@master] Add a link: don't auto-advance when acceptance is de-selected
Comment Actions
I've merged the patch because it does that the task says, but I wanted to also ask about going back and tapping on the ellipses button to view rejection reasons – @RHo should that interaction trigger auto-advance? I would think it should not, but wanted to double-check.
Comment Actions
Change 701588 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add a link: don't auto-advance when acceptance is de-selected
Comment Actions
Hi @kostajh that's right. Incidentally, would it be worthwhile to make the logic that *only* selecting triggers auto-advance instead turning it off for these other instances?
Comment Actions
Change 701967 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@master] Add a link: skip auto-advancing when reopening rejection dialog
Comment Actions
Change 701967 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add a link: skip auto-advancing when reopening rejection dialog
Comment Actions
Checked wmf.12 - https://gerrit.wikimedia.org/r/701588 works: no auto-advancing when Yes/No are toggled.
Add a link: skip auto-advancing when reopening rejection dialog (https://gerrit.wikimedia.org/r/701967) is scheduled for wmf.14. Checked in betalabs - works as expected.