Page MenuHomePhabricator

Add a link: desktop animations
Closed, ResolvedPublic

Description

On desktop, the browser window will scroll so that the suggested link content is scrolled to the top of the window (with ~120px space from the top browser edge). The link inspector should appear over the suggestion that's in focus. See example interaction on the Desktop V.10 Figma spec https://www.figma.com/proto/2SONd8P1tsexIB5coMOp8h/Growth-Structured-tasks?node-id=710%3A464&viewport=-3460%2C-3365%2C0.45993807911872864&scaling=min-zoom (click on the "next" button see sample animation). The link inspector fades in/out when scrolling occurs.

Or here's an animated gif (open fullscreen to view in phab):

ezgif.com-gif-maker.gif (1×1 px, 3 MB)

Event Timeline

Change 698059 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: desktop animations

https://gerrit.wikimedia.org/r/698059

Change 698059 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: desktop animations

https://gerrit.wikimedia.org/r/698059

Etonkovidova subscribed.

for @RHo to take a look.
Checked in testwiki wmf.11 -looks according to the specs; in addition to @mewoph gif above, here is the gif from testwiki showing the animation transition between two closely placed add links and the scrolling when the add link item is farther.

animation3_gif.gif (823×1 px, 3 MB)


Just for comparison - I have the gif from May 7 (without this task patches):

next_item_scroll.gif (748×1 px, 1023 KB)

Looks great, thanks all!

for @RHo to take a look.
Checked in testwiki wmf.11 -looks according to the specs; in addition to @mewoph gif above, here is the gif from testwiki showing the animation transition between two closely placed add links and the scrolling when the add link item is farther.

animation3_gif.gif (823×1 px, 3 MB)


Just for comparison - I have the gif from May 7 (without this task patches):

next_item_scroll.gif (748×1 px, 1023 KB)