Page MenuHomePhabricator

Language variant inspector looks all messed up
Closed, ResolvedPublic

Description

Language variant inspector looks all messed up. The paddings are missing, the toolbar doesn't fit, there are scrollbars for no reason.

image.png (1×807 px, 79 KB)

Event Timeline

Change 698249 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Fix adding 've-init-mw-target-surface' class only to main surface

https://gerrit.wikimedia.org/r/698249

Change 698250 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Make .ve-init-mw-target-surface styles not apply to nested non-target surfaces

https://gerrit.wikimedia.org/r/698250

Using the example from https://www.mediawiki.org/wiki/Parsoid/Language_conversion/Sample_Article:

Before
image.png (2×3 px, 460 KB)
After
image.png (2×3 px, 440 KB)

The problem with toolbar wrapping only occurs with "One-way conversion rule", which has the remove buttons in a funny place. But it might affect other inspectors too in different languages, depending on the length of the labels.

The paddings between various widgets still don't look great to me, but I think it looks the way it was intended to be now.

I'm not planning to do more work on this right now.

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

(Also, there are some undefineds appearing on the editing surface, I'm not looking into that either at this time.)

Change 698249 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix adding 've-init-mw-target-surface' class only to main surface

https://gerrit.wikimedia.org/r/698249

Change 698250 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Make .ve-init-mw-target-surface styles not apply to nested non-target surfaces

https://gerrit.wikimedia.org/r/698250

(Also, there are some undefineds appearing on the editing surface, I'm not looking into that either at this time.)

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/698597

@matmarex: where might I find instructions I can follow to experience what you captured in T284312#7135540?

...reading through Parsoid/Language conversion leads me to wonder whether the above requires me having a local environment where I can enable Pig Latin.[i]


i. "The easiest way for an English-literate developer to test LanguageConverter is to first enable Pig Latin on your test wiki. To do this, add the following line to your LocalSettings.php..."

Yes, I don't think we have any wikis in English with language variants enabled. I used an English-language example hoping to make the issue easier to understand.

You can see the same issue in production on zh.wp though, e.g. https://zh.wikipedia.org/wiki/饿死鬼叭噗?veaction=edit (today's featured article), at the very beginning of the page:

image.png (2×3 px, 1 MB)

(I assume we're not doing product review if this was moved off the board. It's resolved though.)