See also Github issue.
Why needed: Currently on WBstack, MW 1.34 is still running for OAuth internal usage. Having a second service running uses more resources and can be confusing, as there are 2 versions of MW deployed on the platform (one seen by the public & one for internal oauth API calls)
Impact: Making this improvement would reduce resource load on WBstack, which speeds up editing speed “for free”. This could also end up exposing additional bugs in MW 1.35, OAuth, Wikibase or Quickstatements that should be fixed for 3rd party users overall.
Tech notes:
Error that stopped the upgrade originally:
Fatal error: Uncaught Error: Call to undefined method stdClass::doAuthorizationRedirect() in /var/www/html/php/Widar.php:364 Stack trace: #0 /var/www/html/php/Widar.php(68): Widar->authorize() #1 /var/www/html/php/Widar.php(262): Widar->process_request('action') #2 /var/www/html/index.php(27): Widar->render_reponse(false) #3 {main} thrown in /var/www/html/php/Widar.php on line 364Links of interest
- MW 1.34 helm deployment https://github.com/wbstack/deploy/tree/main/k8s/helm/mediawiki134
- Widar still using the 1.34 service https://github.com/wbstack/deploy/blob/1638140fdd2ab70ec6e4c0d63d1cb92d4c17bd7d/k8s/helm/tool-widar/values.yaml.gotmpl#L4
- quickstatements still using the 1.34 service https://github.com/wbstack/deploy/blob/1638140fdd2ab70ec6e4c0d63d1cb92d4c17bd7d/k8s/helm/tool-quickstatements/values.yaml.gotmpl#L4
Acceptance Criteria
- MW 1.34 is no longer deployed on WBstack
- All code for deploying code for MW 1.34 is gone
- Widar and Quickstatements continue to function (i.e. you can log in)
-
If this is a fix elsewhere, it is upstreamed