Page MenuHomePhabricator
Create Task
Maniphest T284367

ResourcesTest::testUnsatisfiableDependencies failing for GlobalWatchlist because wvui no longer targets mobile
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Description

In an unrelated patch

03:07:16 There was 1 failure:
03:07:16 
03:07:16 1) ResourcesTest::testUnsatisfiableDependencies
03:07:16 The module 'ext.globalwatchlist.specialglobalwatchlist.vue' must not have target 'mobile' because its dependency 'wvui' does not have it
03:07:16 Failed asserting that an array contains 'mobile'.
03:07:16 
03:07:16 /workspace/src/tests/phpunit/structure/ResourcesTest.php:113
03:07:16 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:447

Caused by T280828: Create a temporary entry for all WVUI components - the "wvui" module should have its targets restored

Details

SubjectRepoBranchLines +/-
Add 'mobile' as a target for wvui ResourceLoader modulemediawiki/coremaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Jun 5 2021, 10:15 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJun 5 2021, 10:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Jun 5 2021, 10:16 AM

Change 698298 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] Add 'mobile' as a target for wvui ResourceLoader module

https://gerrit.wikimedia.org/r/698298

gerritbot added a project: Patch-For-Review.Jun 5 2021, 10:16 AM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Jun 5 2021, 10:17 AM
DannyS712 moved this task from Backlog to In progress on the MediaWiki-extensions-GlobalWatchlist board.
DannyS712 set the point value for this task to 1.
gerritbot added a comment.Jun 7 2021, 4:59 PM

Change 698298 merged by jenkins-bot:

[mediawiki/core@master] Add 'mobile' as a target for wvui ResourceLoader module

https://gerrit.wikimedia.org/r/698298

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).Jun 7 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 7 2021, 5:10 PM
DannyS712 closed this task as Resolved.Jun 8 2021, 12:49 AM
DannyS712 claimed this task.
DannyS712 moved this task from In progress to Done on the MediaWiki-extensions-GlobalWatchlist board.
DannyS712 set Final Story Points to 1.
Krinkle mentioned this in T127268: Dismantle ResourceLoader's "targets" system.Jun 9 2021, 7:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL