Page MenuHomePhabricator

You have to hit Ctrl+C three times to cancel script
Closed, ResolvedPublicBUG REPORT

Description

Steps to reproduce

  1. Run replace.py script with -pt:10 (or something normal)
  2. Save 20 pages
  3. Hit Ctrl+C
  4. *Script ends, but saving of pages continues*
  5. Hit Ctrl+C
  6. Hit y to cancel pages saving
  7. *pages saving continues*
  8. Hit Ctrl+C again
  9. Hit y to cancel pages saving again

Expected behavior
Previously you had to hit Ctrl+C only twice and y only once.

Current behavior
Currently it requires to do it three times.

Configuration
Pwb master, Python 3.9.5, both mwparserfromhell and wikitextparser pip installed, Linux

Details

Event Timeline

Xqt triaged this task as Medium priority.Jun 6 2021, 2:24 PM
Xqt changed the subtype of this task from "Task" to "Bug Report".

Change 698328 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] clear put_queue when canceling page save

https://gerrit.wikimedia.org/r/698328

Change 698328 merged by jenkins-bot:

[pywikibot/core@master] [bugfix] clear put_queue when canceling page save

https://gerrit.wikimedia.org/r/698328