Page MenuHomePhabricator

Add a link: revisions without the edit summary
Closed, ResolvedPublicBUG REPORT

Description

I have noticed a few "add a link" edits that have the Suggested: add links edit tag, and which do in fact add links, but do not have the expected edit summary (e.g. "2 accepted, 1 rejected, 0 skipped").

Here are two diffs from arwiki:

Unlike in T284217: "newcomer task add link" is assigned to edits irrelevant to structured edits, it looks like these diffs did add links. I suppose the simple explanation would be that these users exited the links workflow and then added links through the editor. But I want to make sure.

Event Timeline

kostajh changed the subtype of this task from "Task" to "Bug Report".Jun 8 2021, 10:05 AM

Change 698783 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] Prevent adding "add links" edit tag when edit is made external to interface

https://gerrit.wikimedia.org/r/698783

I suppose the simple explanation would be that these users exited the links workflow and then added links through the editor. But I want to make sure.

@MMiller_WMF this is my assumption. I took a look at the code and didn't see how it would happen otherwise. @Etonkovidova may want to try to break this to see if it's reproducible, though.

Change 698783 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Prevent adding "add links" edit tag when edit is made external to interface

https://gerrit.wikimedia.org/r/698783

Trying to recreate the suggestions for the old revision of the first example, they don't seem to match. So yeah, I'd assume these are manual edits.

I re-checked for the other SE tasks too - the edits that are done outside of SE workflows (e.g. a user edits an article that is present in SE moduleby searching it) don't get Newcomer task or Suggested: add links tags.

The add link edits will get Visual edit tag which is misleading since the edits not done via VE. However, this is a really minor issue.