Page MenuHomePhabricator

effectively lower Item ID rate limit for bad Item creation requests
Open, Needs TriagePublic5 Estimated Story Points

Description

Problem:
In T272032 we created a rate limit for assigning new Item IDs. There are still a considerable number of IDs being skipped (about 1% atm).

We want to effectively lower the rate limit for bad requests (requests that don't end up creating an Item), while still allowing creating at the same rate as it is possible right now (90/minute).

BDD
GIVEN a API user sending Item creation requests
WHEN a bad request is sent
THEN increase the counter for how much of the rate limit this account is currently using by more than for a successful request

Acceptance criteria:

  • for Wikidata we add 9 to the rate limit counter if Item creation fails when ID generation has happened
  • by default we add 0 to the rate limit counter if Item creation fails when ID generation has happened
  • this value is configurable per installation

Notes:

Event Timeline

Lydia_Pintscher renamed this task from lower Item ID rate limit to lower Item ID rate limit for bad Item creation requests.Tue, Jun 8, 8:29 AM
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher renamed this task from lower Item ID rate limit for bad Item creation requests to effectively lower Item ID rate limit for bad Item creation requests.Wed, Jun 9, 10:21 AM

Change 699266 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Wikibase@master] [WIP] Hook incrementing 'wikibase-idgenerator' ratelimit in case of error

https://gerrit.wikimedia.org/r/699266

Change 699266 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Hook incrementing 'wikibase-idgenerator' ratelimit in case of error

https://gerrit.wikimedia.org/r/699266