Page MenuHomePhabricator
Create Task
Maniphest T284552

Using escape to switch to read mode, then clicking edit again breaks link inspector
Closed, ResolvedPublicBUG REPORT
Actions

Description

There might be other ways to break this as well, this is just the path I observed today:

  • Open link suggestions on an article
  • Press escape twice to get to read mode on the article
  • Click Edit

You'll see the link suggestion interface, but it stops loading after annotations are added with this JS error:

Uncaught TypeError: can't access property "isRejected", this.currentDataModel is undefined
    onYesButtonClicked http://localhost:8080/w/load.php?lang=en&modules=ext.growthExperiments.AddLink|ext.growthExperiments.AddLink.desktop,icons&skin=vector&version=13yze:27
load.php:27:838
    onYesButtonClicked http://localhost:8080/w/load.php?lang=en&modules=ext.growthExperiments.AddLink|ext.growthExperiments.AddLink.desktop,icons&skin=vector&version=13yze:27
    emit jQuery
    onClick http://localhost:8080/w/load.php?lang=en&modules=ext.growthExperiments.AddLink.onboarding|ext.growthExperiments.Help,HelpPanel|ext.growthExperiments.HelpPanel.icons|ext.growthExperiments.HelpPanelCta.styles|ext.growthExperiments.Homepage.icons|mediawiki.pulsatingdot|oojs-ui-core,oojs-ui-widgets,oojs-ui-windows|oojs-ui-core.icons,styles|oojs-ui-widgets.icons|oojs-ui-windows.icons|oojs-ui.styles.icons-editing-advanced,icons-editing-citation,icons-editing-core,icons-interactions,icons-movement,icons-user,indicators&skin=vector&version=1ubx1:144
    <anonymous> self-hosted:1175
    jQuery 10
    setButtonElement http://localhost:8080/w/load.php?lang=en&modules=ext.growthExperiments.AddLink.onboarding|ext.growthExperiments.Help,HelpPanel|ext.growthExperiments.HelpPanel.icons|ext.growthExperiments.HelpPanelCta.styles|ext.growthExperiments.Homepage.icons|mediawiki.pulsatingdot|oojs-ui-core,oojs-ui-widgets,oojs-ui-windows|oojs-ui-core.icons,styles|oojs-ui-widgets.icons|oojs-ui-windows.icons|oojs-ui.styles.icons-editing-advanced,icons-editing-citation,icons-editing-core,icons-interactions,icons-movement,icons-user,indicators&skin=vector&version=1ubx1:143
    setButtonElement http://localhost:8080/w/load.php?lang=en&modules=ext.growthExperiments.AddLink.onboarding|ext.growthExperiments.Help,HelpPanel|ext.growthExperiments.HelpPanel.icons|ext.growthExperiments.HelpPanelCta.styles|ext.growthExperiments.Homepage.icons|mediawiki.pulsatingdot|oojs-ui-core,oojs-ui-widgets,oojs-ui-windows|oojs-ui-core.icons,styles|oojs-ui-widgets.icons|oojs-ui-windows.icons|oojs-ui.styles.icons-editing-advanced,icons-editing-citation,icons-editing-core,icons-interactions,icons-movement,icons-user,indicators&skin=vector&version=1ubx1:332
    OoUiMixinButtonElement http://localhost:8080/w/load.php?lang=en&modules=ext.growthExperiments.AddLink.onboarding|ext.growthExperiments.Help,HelpPanel|ext.growthExperiments.HelpPanel.icons|ext.growthExperiments.HelpPanelCta.styles|ext.growthExperiments.Homepage.icons|mediawiki.pulsatingdot|oojs-ui-core,oojs-ui-widgets,oojs-ui-windows|oojs-ui-core.icons,styles|oojs-ui-widgets.icons|oojs-ui-windows.icons|oojs-ui.styles.icons-editing-advanced,icons-editing-citation,icons-editing-core,icons-interactions,icons-movement,icons-user,indicators&skin=vector&version=1ubx1:142
    OoUiToggleButtonWidget http://localhost:8080/w/load.php?lang=en&modules=ext.growthExperiments.AddLink.onboarding|ext.growthExperiments.Help,HelpPanel|ext.growthExperiments.HelpPanel.icons|ext.growthExperiments.HelpPanelCta.styles|ext.growthExperiments.Homepage.icons|mediawiki.pulsatingdot|oojs-ui-core,oojs-ui-widgets,oojs-ui-windows|oojs-ui-core.icons,styles|oojs-ui-widgets.icons|oojs-ui-windows.icons|oojs-ui.styles.icons-editing-advanced,icons-editing-citation,icons-editing-core,icons-interactions,icons-movement,icons-user,indicators&skin=vector&version=1ubx1:330
    setupButtons http://localhost:8080/w/load.php?lang=en&modules=ext.growthExperiments.AddLink|ext.growthExperiments.AddLink.desktop,icons&skin=vector&version=13yze:35
    initialize http://localhost:8080/w/load.php?lang=en&modules=ext.growthExperiments.AddLink|ext.growthExperiments.AddLink.desktop,icons&skin=vector&version=13yze:25
    initialize http://localhost:8080/w/load.php?lang=en&modules=ext.growthExperiments.AddLink|ext.growthExperiments.AddLink.desktop,icons&skin=vector&version=13yze:55
    setManager http://localhost:8080/w/load.php?lang=en&modules=ext.growthExperiments.AddLink.onboarding|ext.growthExperiments.Help,HelpPanel|ext.growthExperiments.HelpPanel.icons|ext.growthExperiments.HelpPanelCta.styles|ext.growthExperiments.Homepage.icons|mediawiki.pulsatingdot|oojs-ui-core,oojs-ui-widgets,oojs-ui-windows|oojs-ui-core.icons,styles|oojs-ui-widgets.icons|oojs-ui-windows.icons|oojs-ui.styles.icons-editing-advanced,icons-editing-citation,icons-editing-core,icons-interactions,icons-movement,icons-user,indicators&skin=vector&version=1ubx1:399
    addWindows http://localhost:8080/w/load.php?lang=en&modules=ext.growthExperiments.AddLink.onboarding|ext.growthExperiments.Help,HelpPanel|ext.growthExperiments.HelpPanel.icons|ext.growthExperiments.HelpPanelCta.styles|ext.growthExperiments.Homepage.icons|mediawiki.pulsatingdot|oojs-ui-core,oojs-ui-widgets,oojs-ui-windows|oojs-ui-core.icons,styles|oojs-ui-widgets.icons|oojs-ui-windows.icons|oojs-ui.styles.icons-editing-advanced,icons-editing-citation,icons-editing-core,icons-interactions,icons-movement,icons-user,indicators&skin=vector&version=1ubx1:392
    getWindow http://localhost:8080/w/load.php?lang=en&modules=ext.growthExperiments.AddLink.onboarding|ext.growthExperiments.Help,HelpPanel|ext.growthExperiments.HelpPanel.icons|ext.growthExperiments.HelpPanelCta.styles|ext.growthExperiments.Homepage.icons|mediawiki.pulsatingdot|oojs-ui-core,oojs-ui-widgets,oojs-ui-windows|oojs-ui-core.icons,styles|oojs-ui-widgets.icons|oojs-ui-windows.icons|oojs-ui.styles.icons-editing-advanced,icons-editing-citation,icons-editing-core,icons-interactions,icons-movement,icons-user,indicators&skin=vector&version=1ubx1:387
    open http://localhost:8080/w/load.php?lang=en&modules=ext.visualEditor.articleTarget,base,core,desktopArticleTarget,desktopTarget,diffing,icons,language,mediawiki,mwalienextension,mwcore,mwextensions,mwformatting,mwgallery,mwimage,mwlanguage,mwlink,mwmeta,mwsave,mwsignature,mwtransclusion,sanitize,switching,welcome|ext.visualEditor.core.desktop,utils|ext.visualEditor.mwextensions.desktop|ext.visualEditor.mwimage.core&skin=vector&version=q3uob:778
    jQuery 3
    open http://localhost:8080/w/load.php?lang=en&modules=ext.visualEditor.articleTarget,base,core,desktopArticleTarget,desktopTarget,diffing,icons,language,mediawiki,mwalienextension,mwcore,mwextensions,mwformatting,mwgallery,mwimage,mwlanguage,mwlink,mwmeta,mwsave,mwsignature,mwtransclusion,sanitize,switching,welcome|ext.visualEditor.core.desktop,utils|ext.visualEditor.mwextensions.desktop|ext.visualEditor.mwimage.core&skin=vector&version=q3uob:778
    jQuery 8
    open http://localhost:8080/w/load.php?lang=en&modules=ext.visualEditor.articleTarget,base,core,desktopArticleTarget,desktopTarget,diffing,icons,language,mediawiki,mwalienextension,mwcore,mwextensions,mwformatting,mwgallery,mwimage,mwlanguage,mwlink,mwmeta,mwsave,mwsignature,mwtransclusion,sanitize,switching,welcome|ext.visualEditor.core.desktop,utils|ext.visualEditor.mwextensions.desktop|ext.visualEditor.mwimage.core&skin=vector&version=q3uob:778
    toggle http://localhost:8080/w/load.php?lang=en&modules=ext.visualEditor.articleTarget,base,core,desktopArticleTarget,desktopTarget,diffing,icons,language,mediawiki,mwalienextension,mwcore,mwextensions,mwformatting,mwgallery,mwimage,mwlanguage,mwlink,mwmeta,mwsave,mwsignature,mwtransclusion,sanitize,switching,welcome|ext.visualEditor.core.desktop,utils|ext.visualEditor.mwextensions.desktop|ext.visualEditor.mwimage.core&skin=vector&version=q3uob:780
    executeWithSource http://localhost:8080/w/load.php?lang=en&modules=ext.visualEditor.articleTarget,base,core,desktopArticleTarget,desktopTarget,diffing,icons,language,mediawiki,mwalienextension,mwcore,mwextensions,mwformatting,mwgallery,mwimage,mwlanguage,mwlink,mwmeta,mwsave,mwsignature,mwtransclusion,sanitize,switching,welcome|ext.visualEditor.core.desktop,utils|ext.visualEditor.mwextensions.desktop|ext.visualEditor.mwimage.core&skin=vector&version=q3uob:666
    execute http://localhost:8080/w/load.php?lang=en&modules=ext.visualEditor.articleTarget,base,core,desktopArticleTarget,desktopTarget,diffing,icons,language,mediawiki,mwalienextension,mwcore,mwextensions,mwformatting,mwgallery,mwimage,mwlanguage,mwlink,mwmeta,mwsave,mwsignature,mwtransclusion,sanitize,switching,welcome|ext.visualEditor.core.desktop,utils|ext.visualEditor.mwextensions.desktop|ext.visualEditor.mwimage.core&skin=vector&version=q3uob:695
    executeCommand http://localhost:8080/w/load.php?lang=en&modules=ext.visualEditor.articleTarget,base,core,desktopArticleTarget,desktopTarget,diffing,icons,language,mediawiki,mwalienextension,mwcore,mwextensions,mwformatting,mwgallery,mwimage,mwlanguage,mwlink,mwmeta,mwsave,mwsignature,mwtransclusion,sanitize,switching,welcome|ext.visualEditor.core.desktop,utils|ext.visualEditor.mwextensions.desktop|ext.visualEditor.mwimage.core&skin=vector&version=q3uob:667
    selectFirstRecommendation http://localhost:8080/w/load.php?lang=en&modules=ext.growthExperiments.AddLink|ext.growthExperiments.AddLink.desktop,icons&skin=vector&version=13yze:3
    <anonymous> self-hosted:1175
    fire jQuery
    showDialogIfEligible http://localhost:8080/w/load.php?lang=en&modules=ext.growthExperiments.AddLink.onboarding|ext.growthExperiments.Help,HelpPanel|ext.growthExperiments.HelpPanel.icons|ext.growthExperiments.HelpPanelCta.styles|ext.growthExperiments.Homepage.icons|mediawiki.pulsatingdot|oojs-ui-core,oojs-ui-widgets,oojs-ui-windows|oojs-ui-core.icons,styles|oojs-ui-widgets.icons|oojs-ui-windows.icons|oojs-ui.styles.icons-editing-advanced,icons-editing-citation,icons-editing-core,icons-interactions,icons-movement,icons-user,indicators&skin=vector&version=1ubx1:2
    fire jQuery
    afterSurfaceReady http://localhost:8080/w/load.php?lang=en&modules=ext.growthExperiments.AddLink|ext.growthExperiments.AddLink.desktop,icons&skin=vector&version=13yze:3
    <anonymous> self-hosted:1175
    (Async: setTimeout handler)
    surfaceReady http://localhost:8080/w/load.php?lang=en&modules=ext.growthExperiments.AddLink|ext.growthExperiments.AddLink.desktop,icons&skin=vector&version=13yze:53
    addSurface http://localhost:8080/w/load.php?lang=en&modules=ext.visualEditor.articleTarget,base,core,desktopArticleTarget,desktopTarget,diffing,icons,language,mediawiki,mwalienextension,mwcore,mwextensions,mwformatting,mwgallery,mwimage,mwlanguage,mwlink,mwmeta,mwsave,mwsignature,mwtransclusion,sanitize,switching,welcome|ext.visualEditor.core.desktop,utils|ext.visualEditor.mwextensions.desktop|ext.visualEditor.mwimage.core&skin=vector&version=q3uob:1052
    (Async: setTimeout handler)
    addSurface http://localhost:8080/w/load.php?lang=en&modules=ext.visualEditor.articleTarget,base,core,desktopArticleTarget,desktopTarget,diffing,icons,language,mediawiki,mwalienextension,mwcore,mwextensions,mwformatting,mwgallery,mwimage,mwlanguage,mwlink,mwmeta,mwsave,mwsignature,mwtransclusion,sanitize,switching,welcome|ext.visualEditor.core.desktop,utils|ext.visualEditor.mwextensions.desktop|ext.visualEditor.mwimage.core&skin=vector&version=q3uob:1052
    addSurface http://localhost:8080/w/load.php?lang=en&modules=ext.visualEditor.articleTarget,base,core,desktopArticleTarget,desktopTarget,diffing,icons,language,mediawiki,mwalienextension,mwcore,mwextensions,mwformatting,mwgallery,mwimage,mwlanguage,mwlink,mwmeta,mwsave,mwsignature,mwtransclusion,sanitize,switching,welcome|ext.visualEditor.core.desktop,utils|ext.visualEditor.mwextensions.desktop|ext.visualEditor.mwimage.core&skin=vector&version=q3uob:930
    setupSurface http://localhost:8080/w/load.php?lang=en&modules=ext.visualEditor.articleTarget,base,core,desktopArticleTarget,desktopTarget,diffing,icons,language,mediawiki,mwalienextension,mwcore,mwextensions,mwformatting,mwgallery,mwimage,mwlanguage,mwlink,mwmeta,mwsave,mwsignature,mwtransclusion,sanitize,switching,welcome|ext.visualEditor.core.desktop,utils|ext.visualEditor.mwextensions.desktop|ext.visualEditor.mwimage.core&skin=vector&version=q3uob:1052
    (Async: setTimeout handler)
    setupSurface http://localhost:8080/w/load.php?lang=en&modules=ext.visualEditor.articleTarget,base,core,desktopArticleTarget,desktopTarget,diffing,icons,language,mediawiki,mwalienextension,mwcore,mwextensions,mwformatting,mwgallery,mwimage,mwlanguage,mwlink,mwmeta,mwsave,mwsignature,mwtransclusion,sanitize,switching,welcome|ext.visualEditor.core.desktop,utils|ext.visualEditor.mwextensions.desktop|ext.visualEditor.mwimage.core&skin=vector&version=q3uob:1052
    (Async: setTimeout handler)
    setupSurface http://localhost:8080/w/load.php?lang=en&modules=ext.visualEditor.articleTarget,base,core,desktopArticleTarget,desktopTarget,diffing,icons,language,mediawiki,mwalienextension,mwcore,mwextensions,mwformatting,mwgallery,mwimage,mwlanguage,mwlink,mwmeta,mwsave,mwsignature,mwtransclusion,sanitize,switching,welcome|ext.visualEditor.core.desktop,utils|ext.visualEditor.mwextensions.desktop|ext.visualEditor.mwimage.core&skin=vector&version=q3uob:1051
    documentReady http://localhost:8080/w/load.php?lang=en&modules=ext.visualEditor.articleTarget,base,core,desktopArticleTarget,desktopTarget,diffing,icons,language,mediawiki,mwalienextension,mwcore,mwextensions,mwformatting,mwgallery,mwimage,mwlanguage,mwlink,mwmeta,mwsave,mwsignature,mwtransclusion,sanitize,switching,welcome|ext.visualEditor.core.desktop,utils|ext.visualEditor.mwextensions.desktop|ext.visualEditor.mwimage.core&skin=vector&version=q3uob:1050
    documentReady http://localhost:8080/w/load.php?lang=en&modules=ext.visualEditor.articleTarget,base,core,desktopArticleTarget,desktopTarget,diffing,icons,language,mediawiki,mwalienextension,mwcore,mwextensions,mwformatting,mwgallery,mwimage,mwlanguage,mwlink,mwmeta,mwsave,mwsignature,mwtransclusion,sanitize,switching,welcome|ext.visualEditor.core.desktop,utils|ext.visualEditor.mwextensions.desktop|ext.visualEditor.mwimage.core&skin=vector&version=q3uob:8
    loadSuccess http://localhost:8080/w/load.php?lang=en&modules=ext.visualEditor.articleTarget,base,core,desktopArticleTarget,desktopTarget,diffing,icons,language,mediawiki,mwalienextension,mwcore,mwextensions,mwformatting,mwgallery,mwimage,mwlanguage,mwlink,mwmeta,mwsave,mwsignature,mwtransclusion,sanitize,switching,welcome|ext.visualEditor.core.desktop,utils|ext.visualEditor.mwextensions.desktop|ext.visualEditor.mwimage.core&skin=vector&version=q3uob:6
    loadSuccess http://localhost:8080/w/load.php?lang=en&modules=ext.visualEditor.articleTarget,base,core,desktopArticleTarget,desktopTarget,diffing,icons,language,mediawiki,mwalienextension,mwcore,mwextensions,mwformatting,mwgallery,mwimage,mwlanguage,mwlink,mwmeta,mwsave,mwsignature,mwtransclusion,sanitize,switching,welcome|ext.visualEditor.core.desktop,utils|ext.visualEditor.mwextensions.desktop|ext.visualEditor.mwimage.core&skin=vector&version=q3uob:933
    loadSuccess http://localhost:8080/w/load.php?lang=en&modules=ext.growthExperiments.AddLink|ext.growthExperiments.AddLink.desktop,icons&skin=vector&version=13yze:52

Details

SubjectRepoBranchLines +/-
Add a link: Override desktop Esc behaviormediawiki/extensions/GrowthExperimentsmaster+25 -1
Customize query in gerrit

Event Timeline

kostajh created this task.Jun 8 2021, 11:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2021, 11:00 AM
kostajh changed the subtype of this task from "Task" to "Bug Report".Jun 8 2021, 11:01 AM
kostajh added a subscriber: Etonkovidova.
kostajh triaged this task as Medium priority.Jun 8 2021, 1:26 PM
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
• mewoph added a comment.Jun 8 2021, 9:30 PM

onYesButtonClicked should not be called upon load.

• mewoph claimed this task.Jun 21 2021, 4:29 PM
• mewoph moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
• mewoph added a comment.Jun 22 2021, 8:38 PM

I was unable to reproduce this exact error. However I did run into a similar behavior where suggestions mode remain open but link inspector toolbar dialog isn't shown. From my logs, ve.init.mw.DesktopArticleTarget.prototype.onDocumentKeyDown is called — this will close toolbar dialogs when the keydown event is propagated. In our case, I don't think this behavior should apply. In normal VE mode, when there are context items or toolbar dialogs open, upon Escape keydown, these are closed while VE remains open. In our case, the link inspector behaves as if it's part of the surface so Esc should close the editor.

gerritbot added a comment.Jun 22 2021, 9:01 PM

Change 700987 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: Override desktop Esc behavior

https://gerrit.wikimedia.org/r/700987

gerritbot added a project: Patch-For-Review.Jun 22 2021, 9:01 PM
• mewoph added a comment.Jun 22 2021, 9:02 PM

With latest changes:

addlink_esc.gif (484×640 px, 2 MB)

• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 22 2021, 9:02 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 23 2021, 12:39 PM
gerritbot added a comment.Jun 23 2021, 1:00 PM

Change 700987 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: Override desktop Esc behavior

https://gerrit.wikimedia.org/r/700987

Maintenance_bot removed a project: Patch-For-Review.Jun 23 2021, 1:10 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jun 23 2021, 2:00 PM
kostajh moved this task from Backlog to Done / QA on the Add-Link board.Jul 8 2021, 5:22 PM
Etonkovidova closed this task as Resolved.Jul 23 2021, 6:23 PM

Checked on cswiki wmf.15 - following the steps described in the task:

  • Open link suggestions on an article
  • Press escape twice to get to read mode on the article
  • Click Edit

You'll see the link suggestion interface, but it stops loading [...]

The current behavior:

  • Open link suggestions on an article
  • Press escape twice to get to read mode on the article
  • Click Edit

The link suggestion interface is successfully loaded - javascript errors are not present.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL