Page MenuHomePhabricator

Add message linking to project page for feedback
Closed, ResolvedPublic3 Estimated Story Points

Description

Background

Users may notice changes to the search results they see, but without a message they most likely will not know where to share if they find it helpful or if they run into problems. We will add a message to help create that link.

Note: This is temporary – for a few months, probably – and will need a follow up ticket to be removed. Deploy to small default wikis only. TBD if this will remain after small default, possibly with a modified text.

Requirements

  • Add a message using OOUI notice style to both:
    • VisualEditor
    • Template Wizard

Nice to have:

  • Close button which sets a cookie/localStorage, so the user doesn't have to see again if they don't want to. Should be a cookie/localStorage for registered users as well. --> T284742

Text: "Recent work was completed to improve template search results. To learn more about the changes or leave feedback, go to [the project’s page]."
"Kürzlich wurden Änderungen vorgenommen, um die Suchergebnisse für Vorlagen zu verbessern. Mehr Informationen über die Neuerungen finden sich auf der [Projektseite]. Dort kann auch Feedback gegeben werden."

Link for all non-de: https://meta.wikimedia.org/wiki/WMDE_Technical_Wishes/Finding_and_inserting_templates
Link for de wiki: https://de.wikipedia.org/wiki/Wikipedia:Technische_W%C3%BCnsche/Topw%C3%BCnsche/Vorlagen_suchen_und_einf%C3%BCgen

Mocks

Add search instructions.png (538×558 px, 55 KB)

TemplateWizard.png (608×722 px, 30 KB)

Implementation

ooui element message widget to display warning, similar to solution in T272355, but with type "info" instead

Related Objects

Event Timeline

ECohen_WMDE renamed this task from DRAFT: Add message linking to project page for feedback to Add message linking to project page for feedback.Jun 8 2021, 1:21 PM
ECohen_WMDE updated the task description. (Show Details)
Lena_WMDE set the point value for this task to 5.

Change 699050 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/VisualEditor@master] Add message linking to project page for feedback

https://gerrit.wikimedia.org/r/699050

@ECohen_WMDE Should we make the link to the project page open in a new tab? Otherwise possible edits might get lost.

Change 699158 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/TemplateWizard@master] Add message linking to project page for feedback

https://gerrit.wikimedia.org/r/699158

Change 699190 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] Use a new tab when linking to the project page for feedback

https://gerrit.wikimedia.org/r/699190

@Lena_WMDE Ok, the link is opening now in a separate tab. 🎉
Two other questions came up: 🤔

  1. In my opinion, adding the option of hiding the info message might be not useful without the option to display it again (e.g. similar to popups extension). If a user wants to give feedback, but dismissed the info before there is only the option of deleting the browser cache. So I would suggest not implementing the hide option and always display it.
  2. The different language versions of the pages lead to problems with the locals, because the pages are on different wikis (we can not pass language as a parameter). Could we maybe move both language pages on the same side? Or would it maybe be possible to link only to one page and make the other language version visible there? Another solution could be that we create our own german translation and insert the german link there.

I'm just chiming in with some precedents: for (1), there is already the VE welcome dialog, which is dismissed permanently (in this case, using a user option flag so this is an even harder "hidden"). CentralNotice is similar, messages never reappear once dismissed. I think editors are happy with this arrangement, their main interest is to dismiss messages and not to get them to appear again. There is nothing functional in our message, like reenabling a feature, it's just informational. For (2), just to clarify the convention is to use Special:MyLanguage to route to a page translation. For example, our link would be https://meta.wikimedia.org/wiki/Special:MyLanguage/WMDE_Technical_Wishes/Finding_and_inserting_templates

I'm not sure what type of translation has already been used on this page, by the way? @JStrodt_WMDE maybe you know? I don't recognize this language dropdown.

Change 699197 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/TemplateWizard@master] Use a new tab when linking to the project page for feedback

https://gerrit.wikimedia.org/r/699197

I second @awight 's comment. This being permanently dismissable (except that it would reappear if a user clears their cookies) is pretty standard practice and fine for this type of message. Regarding translation, I would just like to follow the convention as Adam described (maybe you can help with the imlementation there @awight). Thanks!

(1) I created a subticket to add the "nice to have" close button: T284742. This way the current implementation can already be reviewed and deployed. 🤓
I am also removing two point here and adding them to the subticket.

(2) Concerning the language links: Are there plans to create the project page in other languages as well @Lena_WMDE ? If not, adding a translation to the page, might be an overkill. If yes, than this approach would be perfect, I think. :)

lilients_WMDE changed the point value for this task from 5 to 3.Jun 10 2021, 1:22 PM
lilients_WMDE updated the task description. (Show Details)

@lilients_WMDE there are no plans to translate the project page to more languages, but we do have it in German and we typically implement the translation to German with the link to the German page to facilitate easier feedback from and on dewiki. Having to look for the German page or having to provide feedback in English has been cited as a barrier to providing feedback and frustration on the part of dewiki users, and since there is an easy fix for that we typically do this. I don't think this is particularly complicated either (following the approach Adam mentioned above), and has been done in the past for these types of messages - would just consult with the other devs.

I am sure it makes absolutly sense to have both language versions! 👍 Maybe the easiest solution would be to add the german translation ourselves and add the different link there (I will make a patch for this). Maybe we can also combine this with @awight 's proposed translation, though I am not sure how this could be implemented. 🤔

Change 699224 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/VisualEditor@master] Add german translation for feedback message to set special link to german project page

https://gerrit.wikimedia.org/r/699224

Change 699050 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Add message linking to project page for feedback

https://gerrit.wikimedia.org/r/699050

Change 699158 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] Add message linking to project page for feedback

https://gerrit.wikimedia.org/r/699158

Change 699197 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] Use a new tab when linking to the project page for feedback

https://gerrit.wikimedia.org/r/699197

Change 699190 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Use a new tab when linking to the project page for feedback

https://gerrit.wikimedia.org/r/699190

@awight @lilients_WMDE I changed the German text a bit because the formal address "Sie" is very uncommon on dewiki.

Change 699224 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/VisualEditor@master] Add german translation for feedback message to set special link to german project page

Reason:

This needs to be done at https://translatewiki.net/wiki/MediaWiki:Visualeditor-dialog-transclusion-feedback-message/de. As of now it's already translated, but the translations are a bit different. Please compare the two and let me know if the translation at translatewiki.net needs to change. The different link is already fixed.

Note: Im Deutschen siezen wir unsere Benutzer eigentlich nie.

https://gerrit.wikimedia.org/r/699224