Page MenuHomePhabricator
Create Task
Maniphest T284567

[regression] Reply tool padding and height broken
Closed, ResolvedPublic
Actions

Description

Expected:

image.png (192×575 px, 5 KB)
image.png (196×571 px, 6 KB)

Actual

image.png (82×921 px, 4 KB)
image.png (104×930 px, 5 KB)

Tagging desktop improvements as they are making changes to CSS, but haven't identified the cause.

Details

SubjectRepoBranchLines +/-
Update surface styles for VE changesmediawiki/extensions/DiscussionToolswmf/1.37.0-wmf.9+7 -7
Update surface styles for VE changesmediawiki/extensions/DiscussionToolsmaster+7 -7
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasejeenaT281150 1.37.0-wmf.9 deployment blockers
 ResolvedmatmarexT284567 [regression] Reply tool padding and height broken

Event Timeline

Esanders created this task.Jun 8 2021, 1:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2021, 1:36 PM
Esanders triaged this task as Unbreak Now! priority.Jun 8 2021, 1:36 PM
matmarex added a comment.Jun 8 2021, 1:50 PM

May be also my fault from the surface class changes.

R4356th subscribed.Jun 8 2021, 1:51 PM
RhinosF1 subscribed.Jun 8 2021, 2:08 PM
matmarex added a parent task: T281150: 1.37.0-wmf.9 deployment blockers.Jun 8 2021, 2:30 PM
DannyS712 added a project: Regression.Jun 8 2021, 3:01 PM
• ppelberg subscribed.Jun 8 2021, 3:04 PM
matmarex claimed this task.Jun 8 2021, 3:38 PM
matmarex added a project: Editing-team (Kanban Board).
matmarex removed a project: Desktop Improvements (Vector 2022).Jun 8 2021, 3:57 PM
gerritbot added a comment.Jun 8 2021, 4:04 PM

Change 698814 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Update surface styles for VE changes

https://gerrit.wikimedia.org/r/698814

gerritbot added a project: Patch-For-Review.Jun 8 2021, 4:04 PM
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Jun 8 2021, 4:05 PM
Esanders added a comment.Jun 8 2021, 4:30 PM

Apologies to the web team for the speculative tagging, turned out to be just an internal issue.

gerritbot added a comment.Jun 8 2021, 4:35 PM

Change 698814 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Update surface styles for VE changes

https://gerrit.wikimedia.org/r/698814

Maintenance_bot removed a project: Patch-For-Review.Jun 8 2021, 5:10 PM
gerritbot added a comment.Jun 8 2021, 5:41 PM

Change 698681 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.37.0-wmf.9] Update surface styles for VE changes

https://gerrit.wikimedia.org/r/698681

gerritbot added a project: Patch-For-Review.Jun 8 2021, 5:41 PM
jeena subscribed.Jun 8 2021, 7:22 PM

Is this patch expected to resolve the issue? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/698681/ (shall I merge it and deploy to group0?)

matmarex added a comment.Jun 8 2021, 7:37 PM

Yes please. The usual backport slot where I'd do that was cancelled today for some reason.

jeena added a comment.Jun 8 2021, 7:39 PM

Thanks!

gerritbot added a comment.Jun 8 2021, 7:47 PM

Change 698681 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.37.0-wmf.9] Update surface styles for VE changes

https://gerrit.wikimedia.org/r/698681

jeena added a comment.Jun 8 2021, 7:55 PM

deployed to group0

Maintenance_bot removed a project: Patch-For-Review.Jun 8 2021, 8:10 PM
matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Jun 8 2021, 8:48 PM
Stashbot added a comment.Jun 9 2021, 9:42 PM

Mentioned in SAL (#wikimedia-operations) [2021-06-09T21:42:32Z] <ladsgroup@deploy1002> Synchronized php-1.37.0-wmf.9/extensions/DiscussionTools/modules/dt-ve/CommentTargetWidget.less: Backport: [[gerrit:698681|Update surface styles for VE changes (T284567)]] (duration: 01m 14s)

jeena added a comment.Jun 10 2021, 4:21 PM

@matmarex @ppelberg can you confirm this is resolved now since it is a train blocker?

• ppelberg closed this task as Resolved.Jun 10 2021, 4:34 PM
In T284567#7149360, @jeena wrote:

@matmarex @ppelberg can you confirm this is resolved now since it is a train blocker?

Thank you for the nudge, @jeena – looks good to me. Resolving.

jeena added a comment.Jun 10 2021, 4:42 PM

thanks! :)

valhallasw mentioned this in T284587: ReleaseTaggerBot skipping some Tasks/Patches?.Jun 12 2021, 8:03 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 12 2021, 8:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL