Page MenuHomePhabricator

Userlinks: Remove SkinVector::ICON_USER_LINK_MAP
Closed, ResolvedPublic3 Estimated Story Points

Description

SkinVector class has an Icon map which maps menu items to their corresponding menu items:
https://github.com/wikimedia/Vector/blob/master/includes/Hooks.php#L29

The betafeatures key comes from Extension:betafeatures and all the other icons come from core.

Instead of having the map here, I suggest we continue the approach in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SandboxLink/+/698066 and declare these icons at time of creation rather than Vector.

This will help us in future when we want to use such icons in other skins e.g. MinervaNeue

Event Timeline

Jdlrobson renamed this task from Remove SkinVector::ICON_USER_LINK_MAP to Userlinks: Remove SkinVector::ICON_USER_LINK_MAP .Jun 8 2021, 7:25 PM
Jdlrobson assigned this task to ovasileva.
Jdlrobson triaged this task as Medium priority.
Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.

@cjming what do you think?

makes sense to me!

Change 700995 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/extensions/BetaFeatures@master] Add labFlask icon to beta features link

https://gerrit.wikimedia.org/r/700995

Change 700996 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/core@master] Add icon to personal url menu items

https://gerrit.wikimedia.org/r/700996

Change 700997 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] Remove SkinVector::ICON_USER_LINK_MAP usage

https://gerrit.wikimedia.org/r/700997

nray removed nray as the assignee of this task.Jun 22 2021, 11:21 PM
nray added a subscriber: nray.

Change 700995 merged by jenkins-bot:

[mediawiki/extensions/BetaFeatures@master] Add labFlask icon to beta features link

https://gerrit.wikimedia.org/r/700995

phuedx added a subscriber: phuedx.

@Jdlrobson: It looks like you've started reviewing @nray's patches so I'm being bold and assigning this task to you.

Change 700996 merged by jenkins-bot:

[mediawiki/core@master] Add icon to personal url menu items

https://gerrit.wikimedia.org/r/700996

Change 700997 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove SkinVector::ICON_USER_LINK_MAP usage

https://gerrit.wikimedia.org/r/700997

this lgtm - since i introduced the tech debt, happy to see this done