Page MenuHomePhabricator
Create Task
Maniphest T284632

Exploratory patches extracting a high-level interface for the booklet layout
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

The current interface to BookletLayout is very low-level and requires its caller to have knowledge of its children and perform some of its logic.

  • Introduce a class that will eventually encapsulate some of this interface, giving it a high-level interface like, addPart(id), which creates a sidebar item and content page.
  • Start with the simplest possible interface, just take over one method.
  • Do not wire to the transcluded wikitext if possible, this can stay a TemplateDialog responsibility.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Method for getting the currently selected elementmediawiki/extensions/VisualEditormaster+22 -13
Introduce a new class to encapsulate booklet inter-pane wiringmediawiki/extensions/VisualEditormaster+45 -25
Customize query in gerrit

Related Objects
Search...

Event Timeline

awight created this task.Jun 9 2021, 10:05 AM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJun 9 2021, 10:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Jun 9 2021, 10:12 AM

Change 698191 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Introduce a new class to encapsulate booklet inter-pane wiring

https://gerrit.wikimedia.org/r/698191

gerritbot added a project: Patch-For-Review.Jun 9 2021, 10:12 AM

Change 698573 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Method for getting the currently selected element

https://gerrit.wikimedia.org/r/698573

awight added a project: WMDE-TechWish-Sprint-2021-05-26.Jun 9 2021, 10:12 AM
awight moved this task from Sprint Backlog to Review on the WMDE-TechWish-Sprint-2021-05-26 board.
awight set the point value for this task to 0.
awight moved this task from Backlog to In sprint on the WMDE-Templates-FocusArea board.Jun 9 2021, 10:39 AM
Tobi_WMDE_SW added a project: WMDE-FUN-Sprint-2021-06-07.Jun 9 2021, 11:14 AM
awight removed awight as the assignee of this task.Jun 9 2021, 11:14 AM
awight added a project: WMDE-TechWish-Sprint-2021-06-09.
Tobi_WMDE_SW moved this task from Sprint Backlog to Review on the WMDE-TechWish-Sprint-2021-06-09 board.Jun 9 2021, 11:15 AM
awight removed a project: WMDE-FUN-Sprint-2021-06-07.Jun 9 2021, 11:16 AM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jun 10 2021, 5:50 PM
gerritbot added a comment.Jun 15 2021, 2:55 PM

Change 698191 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Introduce a new class to encapsulate booklet inter-pane wiring

https://gerrit.wikimedia.org/r/698191

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 15 2021, 3:00 PM
gerritbot added a comment.Jun 16 2021, 7:22 AM

Change 698573 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Method for getting the currently selected element

https://gerrit.wikimedia.org/r/698573

awight closed this task as Resolved.Jun 16 2021, 3:49 PM
awight claimed this task.
awight moved this task from Review to Done on the WMDE-TechWish-Sprint-2021-06-09 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits