Page MenuHomePhabricator

Migrate `remove` interface to high-level booklet class
Closed, DeclinedPublic0 Estimated Story Points

Description

This will take more work than the simpler functions. For this, we need to:

  • Wire wikitext model into booklet helper as a read-only data source. This will be read to find the current template parameter items and remove them. Perhaps in the future this dependency can be dropped in favor of fully encapsulating each template, so we just remove a template-level container.
  • Take over all item removal responsibilities.
  • Take over UI wiring and unwiring.
  • May need to migrate the "reselect" feature, this currently depends on low-level integration with add/remove operations. Document current reselect behavior. Try to leave that behavior unchanged.

Details

Event Timeline

awight set the point value for this task to 0.

Change 698574 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] [WIP] starting to migrate "remove"

https://gerrit.wikimedia.org/r/698574

awight removed awight as the assignee of this task.

Change 698574 abandoned by WMDE-Fisch:

[mediawiki/extensions/VisualEditor@master] [WIP] starting to migrate "remove"

Reason:

Ticket got declined.

https://gerrit.wikimedia.org/r/698574