Page MenuHomePhabricator
Create Task
Maniphest T284685

TypeError: Argument 1 passed to LanguageConverter::__construct() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.37.0-wmf.9/includes/language/LanguageConverterFactory.php on line 132
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   TypeError: Argument 1 passed to LanguageConverter::__construct() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.37.0-wmf.9/includes/language/LanguageConverterFactory.php on line
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.9/includes/language/LanguageConverter.php(84)
#0 /srv/mediawiki/php-1.37.0-wmf.9/includes/language/LanguageConverterFactory.php(132): LanguageConverter->__construct(StubUserLang)
#1 /srv/mediawiki/php-1.37.0-wmf.9/includes/OutputPage.php(2341): MediaWiki\Languages\LanguageConverterFactory->getLanguageConverter(StubUserLang)
#2 /srv/mediawiki/php-1.37.0-wmf.9/includes/OutputPage.php(2448): OutputPage->addAcceptLanguage()
#3 /srv/mediawiki/php-1.37.0-wmf.9/includes/OutputPage.php(2568): OutputPage->sendCacheControl()
#4 /srv/mediawiki/php-1.37.0-wmf.9/includes/MediaWiki.php(931): OutputPage->output(boolean)
#5 /srv/mediawiki/php-1.37.0-wmf.9/includes/MediaWiki.php(944): MediaWiki::{closure}()
#6 /srv/mediawiki/php-1.37.0-wmf.9/includes/MediaWiki.php(551): MediaWiki->main()
#7 /srv/mediawiki/php-1.37.0-wmf.9/index.php(53): MediaWiki->run()
#8 /srv/mediawiki/php-1.37.0-wmf.9/index.php(46): wfIndexMain()
#9 /srv/mediawiki/w/index.php(3): require(string)
#10 {main}
Impact
  • A dozen in the past 4 hours or so
  • Only happening in wmf.9
Notes

Details

Request URL
https://www.mediawiki.org/w/index.php?search=*&title=*&go=*
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
LanguageConverter: document accepting StubUserLangmediawiki/coremaster+3 -3
Revert "Add type hint to constructor of LanguageConverter"mediawiki/corewmf/1.37.0-wmf.9+1 -1
Revert "Add type hint to constructor of LanguageConverter"mediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Jun 9 2021, 6:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 9 2021, 6:30 PM
thcipriani moved this task from Untriaged to June 2021 on the Wikimedia-production-error board.Jun 9 2021, 6:42 PM
gerritbot added a comment.Jun 9 2021, 6:59 PM

Change 699012 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] Revert "Add type hint to constructor of LanguageConverter"

https://gerrit.wikimedia.org/r/699012

gerritbot added a project: Patch-For-Review.Jun 9 2021, 6:59 PM

Change 699013 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] LanguageConverter: document accepting StubUserLang

https://gerrit.wikimedia.org/r/699013

DannyS712 added a comment.Jun 9 2021, 7:03 PM

Sorry, thats my bad - forgot about StubUserLang. Just +2'ed the revert, @thcipriani does it warrant backporting to the train?

jeena subscribed.Jun 9 2021, 7:19 PM

This is happening more since I deployed to group1, so I think a backport would be good @DannyS712

gerritbot added a comment.Jun 9 2021, 7:20 PM

Change 699012 merged by jenkins-bot:

[mediawiki/core@master] Revert "Add type hint to constructor of LanguageConverter"

https://gerrit.wikimedia.org/r/699012

gerritbot added a comment.Jun 9 2021, 7:46 PM

Change 699014 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@wmf/1.37.0-wmf.9] Revert "Add type hint to constructor of LanguageConverter"

https://gerrit.wikimedia.org/r/699014

DannyS712 added a comment.EditedJun 9 2021, 7:46 PM
In T284685#7147021, @jeena wrote:

This is happening more since I deployed to group1, so I think a backport would be good @DannyS712

Sent https://gerrit.wikimedia.org/r/c/mediawiki/core/+/699014 for the backport, marking as a blocker

DannyS712 triaged this task as Unbreak Now! priority.Jun 9 2021, 7:47 PM
DannyS712 added a parent task: T281150: 1.37.0-wmf.9 deployment blockers.
DannyS712 added a project: User-DannyS712.
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 9 2021, 8:00 PM
gerritbot added a comment.Jun 9 2021, 9:22 PM

Change 699014 merged by jenkins-bot:

[mediawiki/core@wmf/1.37.0-wmf.9] Revert "Add type hint to constructor of LanguageConverter"

https://gerrit.wikimedia.org/r/699014

Stashbot added a comment.Jun 9 2021, 9:40 PM

Mentioned in SAL (#wikimedia-operations) [2021-06-09T21:40:43Z] <ladsgroup@deploy1002> Synchronized php-1.37.0-wmf.9/includes/language/LanguageConverter.php: Backport: [[gerrit:699014|Revert "Add type hint to constructor of LanguageConverter" (T284685)]] (duration: 01m 24s)

Ladsgroup closed this task as Resolved.Jun 9 2021, 9:42 PM
Ladsgroup assigned this task to DannyS712.
ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.9; 2021-06-07); removed MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 9 2021, 10:00 PM
Nikerabbit removed a project: Language-Team.Jun 10 2021, 6:13 AM
gerritbot added a comment.May 3 2023, 12:14 PM

Change 699013 abandoned by Winston Sung:

[mediawiki/core@master] LanguageConverter: document accepting StubUserLang

Reason:

Replaced-by: I9b3e87baf38091e2de428de0c92c5a8a6fea32ea

https://gerrit.wikimedia.org/r/699013

Maintenance_bot removed a project: Patch-For-Review.May 3 2023, 12:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits