Page MenuHomePhabricator

Open actions in the Confirm step need adjustment
Open, MediumPublic

Description

As a follow-up from T276221, there are a couple minor details related to the "open" icons that may need adjustment (I'll create separate follow-up tickets for these):

  1. The option to open the selected article is only accessible when taping the small icon next to it. The whole (title including the icon) should be tappable instead.
  2. The open icon showing at the right side of the "Available in X" label is currently opening in the same browser tab. It should open on a new tab to prevent losing the context for the user.

test.m.wikipedia.org_wiki_Special_ContentTranslation(iPhone 6_7_8) (3).png (1×750 px, 114 KB)

1B. The icon for the first option looks a few pixels below the text next to it. Inspecting the icon CSS it seems to use currently vertical-align: middle, using vertical-align: baseline instead may help the icon to sit along the text better. A comparison of the difference is shown below:

Current – vertical align: middleProposed – Vertical align: baseline
test.m.wikipedia.org_wiki_Special_ContentTranslation(iPhone 6_7_8) (3).png (188×750 px, 15 KB)
test.m.wikipedia.org_wiki_Special_ContentTranslation(iPhone 6_7_8) (4).png (188×750 px, 15 KB)

Event Timeline

Change 699189 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX Confirm Translation: Fix external link buttons

https://gerrit.wikimedia.org/r/699189

Change 699189 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX Confirm Translation: Fix external link buttons

https://gerrit.wikimedia.org/r/699189