Page MenuHomePhabricator

Add close button to feedback message in template search
Closed, ResolvedPublic2 Estimated Story Points

Description

Add a close button which sets a cookie/localStorage, so the user doesn't have to see the info message again if they don't want to. Should be a cookie/localStorage for registered users as well. This is a "nice to have" feature.

Implement for:

  • TemplateWizard
  • VisualEditor

Event Timeline

lilients_WMDE renamed this task from Hide feedback message in template search to Add close button to feedback message in template search.Jun 10 2021, 1:15 PM
lilients_WMDE changed the point value for this task from 0 to 2.Jun 10 2021, 1:23 PM

Change 699247 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] [WIP] Dismissible feedback message for the template search

https://gerrit.wikimedia.org/r/699247

Change 699408 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/TemplateWizard@master] Dismissible feedback message for the template search

https://gerrit.wikimedia.org/r/699408

Change 700013 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TemplateWizard@master] Small code cleanups for the DismissibleMessageWidget

https://gerrit.wikimedia.org/r/700013

Change 700022 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Small code cleanups for the MWDismissibleMessageWidget

https://gerrit.wikimedia.org/r/700022

@Lena_WMDE @ECohen_WMDE

Currently the X that's responsible for permanently hiding the dialog has not title, so hovering the icon does not give a hint what it's doing. In Two-Column-Edit-Conflict-Merge where we have a similar hint, we gave it the title Never show again. I suggest to do the same here, so it's a bit more transparent ( and also more a11y compatible I guess ) .

@WMDE-Fisch Good point - and since you mention the a11y aspect, maybe we can also make it a bit clearer for those using screen readers:
"Close message and do not show again."

It's a bit longer but is clearer about the action and what it applies to.

Change 699408 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] Dismissible feedback message for the template search

https://gerrit.wikimedia.org/r/699408

Change 699247 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Dismissible feedback message for the template search

https://gerrit.wikimedia.org/r/699247

Change 700013 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] Small code cleanups for the DismissibleMessageWidget

https://gerrit.wikimedia.org/r/700013

Change 700022 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Small code cleanups for the MWDismissibleMessageWidget

https://gerrit.wikimedia.org/r/700022

Change 700121 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TemplateWizard@master] Add tooltip to "dismissible message" close button

https://gerrit.wikimedia.org/r/700121

Change 700122 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Add tooltip to "dismissible message" close button

https://gerrit.wikimedia.org/r/700122

Change 700121 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] Add tooltip to "dismissible message" close button

https://gerrit.wikimedia.org/r/700121

Change 700122 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Add tooltip to "dismissible message" close button

https://gerrit.wikimedia.org/r/700122

Lena_WMDE moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-06-09 board.