Page MenuHomePhabricator

CentralAuth: unsuppression does not work on locally blocked accounts
Closed, ResolvedPublic

Description

Via CentralAuth you suppress a global account (some local accounts of the global one are locally blocked *without* hideuser). Later you notice that using suppression was a mistake so you uncheck the global suppression option.

The result is that, if the account was locally blocked, it remains suppressed so you need to manually unsuppress it's name and edits on every project.

Happened today at:

Please note that the "hidden" flag only removes it from Special:GlobalUsers but nothing more.

Details

Reference
bz26476

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:19 PM
bzimport set Reference to bz26476.
bzimport added a subscriber: Unknown Object (MLST).

This was done intentionally. Otherwise the global unsuppression would override local unsuppressions (which it surely should not do).

(In reply to comment #1)

This was done intentionally. Otherwise the global unsuppression would override
local unsuppressions (which it surely should not do).

Thank you. It seems that, then, the extension should check which accounts were suppressed by CentralAuth and which ones locally and remove the suppressions set from meta only?

Added dependency on another bug which seems similar to this one too.

Luke081515 added a subscriber: Luke081515.

Resolved, could not reproduce it anymore:

(change visibility) 23:49, 26 April 2016 Luke081515 (talk | contribs | block) changed status for global account "User:Luke081515.2@global": set (none); unset locked, oversighted
23:49, 26 April 2016 Luke081515 (talk | contribs | block) changed status for global account "User:Luke081515.2@global": set locked, oversighted; unset (none) (testing T28476)

and http://deployment.wikimedia.beta.wmflabs.org/w/index.php?title=Special:CentralAuth&target=Luke081515.2&uselang=en shows no blocks...

I'm not sure if this is resolved in production. Can any steward please test this on our live wikis?

I'm not sure I understand this bug. Per T25310, locally blocked accounts (without hideuser) won't be suppressed when the global account is globally suppressed. So an account that hasn't already been suppressed cannot/shouldn't be unsuppressed even when globally unsuppressing. Am I missing something?