Page MenuHomePhabricator

Cannot add language versions of Wikipedia on Commons: "Page" (wikibase-linkitem-input-page) remains disabled in the "Link with page" dialog
Closed, ResolvedPublic8 Estimated Story Points

Description

Problem:
Since a few days it is no longer possible to link Commons pages to their Wikidata Items via the AddLink dialog on the client. It seems the language selection never works. It seems previously we let people select Wikipedia language versions here.

Steps to reproduce:

  1. Go to a Commons category that does not yet have a Wikidata item associated with it - example Category:Coaches of Everton L.F.C.
  2. Click on 'Add links' a the bottom of the sidebar
  3. Enter 'en'
  4. Normally this would present a list of options, and you could select 'enwiki' - but it no longer does this.
  5. Normally you could then enter a page name, but this option remains greyed out, and you can't click the 'link with page' option.

Screenshots/mockups:

2021-06-11 10_43_00-Category_Coaches of Scarborough Athletic FC - Wikimedia Commons — Mozilla Firefo.png (1×1 px, 184 KB)

BDD
GIVEN a page on Wikimedia Commons
AND that page has no Item connected to it on Wikidata
WHEN adding a sitelink via the AddLink dialog on Wikimedia Commons
THEN I can select a Wikipedia language version in the language input field

Acceptance criteria:

  • language selection in the AddLink dialog on Commons works again

Note:

  • It seems the issue is in the backend and not the frontend of the AddLink dialog.

Original report:

By now it is on Commons no longer possible to add site links through the

2021-06-11 10_43_00-Category_Coaches of Scarborough Athletic FC - Wikimedia Commons — Mozilla Firefo.png (1×1 px, 184 KB)

as shown here as soon as you fill in the field for the language the next field page is not accessible.

this is really annoying as you need to manually create the item in wikidata in order to add the interwikilinks.

Event Timeline

Aklapper changed the task status from Open to Stalled.Jun 12 2021, 10:59 AM

@Robby: Thanks for taking the time to report this! Could you please follow https://www.mediawiki.org/wiki/How_to_report_a_bug and provide clear steps to reproduce? I go to https://commons.wikimedia.org/wiki/Category:Coaches_of_Scarborough_Athletic_FC and have no idea what I'm supposed to do and where. Thanks.

Jdlrobson added a subscriber: Jdlrobson.

Can't see any obvious reason why this would relate to desktop improvements work. Code looks pretty isolated and bug reported against old interface.

I believe this relates to the add link in left menu:
If you click “add links” on https://commons.wikimedia.org/wiki/Category:Bernardus_de_Bosch_(II) the second input is disabled. I guess that’s the error?

Mike_Peel updated the task description. (Show Details)

@Aklapper I added steps to reproduce - the original example has now been linked to Wikidata, but you can see the same behaviour in any case that hasn't been linked to Wikipedia yet.

Changing priority to 'high' - I would set it to 'unbreak down' if this issue had affected readers. It's a significant problem for editors though.

Mike_Peel changed the task status from Stalled to Open.Jun 12 2021, 4:02 PM

Thanks. (Only Legacy Vector offers that item in the sidebar, so this doesn't fall under Desktop Improvements.)

Click on 'Add links' at the bottom of the sidebar

No such item:

Screenshot from 2021-06-12 19-49-46.png (934×960 px, 160 KB)

And no such item either after enabling everything on https://commons.wikimedia.org/wiki/Special:Preferences#mw-prefsection-gadgets :

Screenshot from 2021-06-12 19-53-53.png (934×960 px, 165 KB)

Where does "Add links" come from?
Does this also happen when using safemode (see https://www.mediawiki.org/wiki/Help:Locating_broken_scripts )?

Ah, it works on https://commons.wikimedia.org/wiki/Category:Bernardus_de_Bosch_(II) , sorry!

So after clicking wikibase-linkitem-addlinks, wikibase-linkitem-input-page remains disabled. Got it.

Aklapper renamed this task from Add links to language versions of Wikipedia no longer works on Commons to Cannot add language versions of Wikipedia on Commons: "Page" (wikibase-linkitem-input-page) remains disabled in the "Link with page" dialog.Jun 12 2021, 6:01 PM

@Mike_Peel thanks for the updating of the description

@Aklapper unfortunately i had not the necessary tome to give a more precise description by the time of logging the issue (there is a life aside the Wikimedia world) and yes I am very aware of hot to describe software issues (part of my professional tasks)

@Aklapper thanks for updating the title of th issue (now better aligned to the wording of MediaWiki developpers I guess)

This bug was reported also at Commons:Village pump#Interwiki linking disabled? at 05:31, 11 June 2021 (UTC) .

Tested now: at Commons, the problem continues. Language/project selection in the AddLinks form fails.

At en:Wikipedia and cs:Wikipedia: the AddLinks form works correctly.

Change 700120 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Wikibase@master] client: Bring back using the client setting for langling group

https://gerrit.wikimedia.org/r/700120

Change 700036 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.9] client: Bring back using the client setting for langlink group

https://gerrit.wikimedia.org/r/700036

Change 700120 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] client: Bring back using the client setting for langlink group

https://gerrit.wikimedia.org/r/700120

Change 700036 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.9] client: Bring back using the client setting for langlink group

https://gerrit.wikimedia.org/r/700036

Mentioned in SAL (#wikimedia-operations) [2021-06-17T13:28:28Z] <ladsgroup@deploy1002> Synchronized php-1.37.0-wmf.9/extensions/Wikibase/client/includes/ClientHooks.php: Backport: [[gerrit:700036|client: Bring back using the client setting for langlink group (T284854)]] (duration: 00m 58s)

Not sure if this is meant to be fixed or is queued for deployment, but just to say that testing it at the moment shows it still isn't working.

Yeah. It'll go out with the deployment next week. There were no deployments this week because of the WMF all-hands meeting.

Actually we deployed this as it was really tiny and the problem was big (as an emergency deployment). The reason it's not working is that it's behind a one-day-long cache. It's in each server so I can't flush it in every host (unlike memcached values). Just wait for 11 hours ish.

For me it is again working as before. I managed to add the interwikilink for https://commons.wikimedia.org/wiki/Category:Tanmoy_Bhattacharya through the 'link with dialog'.

Thnaks to all those involved in the solution of this.

Seems to be working again for everyone, thanks for fixing it!