Page MenuHomePhabricator

Flood right (or flood flag) for non-administrator users do not display editing as bots while using non-source editor
Open, Needs TriagePublic

Description

Hello, Two days ago, a user (Sakura emad@ckbwiki) asked for flood flag (Flood flag on Simple Wikipedia) to repeat a set of changes and not appear on the Recent changes page, but after I gave the right to Sakura emad, the changes will not be marked as bot yet and will appear on the Recent changes page! As far as I noticed, it only hide the edits made through Source Editor. Editing via Visual Editor will not be marked as bots. Editing by using Gadget-Cat-a-lot will not be marked as bots. See Sakura emad's contributions while the user has flood flag yet. We want all changes marked as bot and disappear on RC page while the user has flood flag. Thanks,

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
AramBakir renamed this task from Flood right (or flood flag) for non-administrator users ) do not display editing as bots while using non-source editor to Flood right (or flood flag) for non-administrator users do not display editing as bots while using non-source editor.Jun 12 2021, 11:52 AM
Urbanecm added a subscriber: Urbanecm.

For cat-a-lot, this is actually not a bug. The bot right means "user can have its edits marked as bot" – API lets bots to not have their edits marked if needed. Inspecting Cat-a-lot's code, it only passes bot: 1 when user is in the bot group (which isn't the case here – the user was in the flood group.

For visualeditor, the editor calls action=visualeditoredit API, which doesn't sound to add bot: 1. Not sure if that's expected, but it's not a bug in recentchanges.

Tagging VisualEditor to get their opinion on whether action=visualeditoredit should pass bot: 1 when user has bot rights. Untagging MediaWiki-Recent-changes, as it's not relevant to RC at all – the flags are set how API tells them to.

Thanks for the reply. If so, the Flood flag has no benefit for users.

Thanks for the reply. If so, the Flood flag has no benefit for users.

It depends on the tooling the user uses to make their edits. The flood flag assigns the user a right called bot, which (roughly) means user "can request their edits to be marked as bot". For catalot, it's simply to fix in the code - any interface admin can do it for you, or I can if you want me to. It behaves similarly to the bot flag.

For visual editor, it _might_ be an oversight on the Editing-team side. Edits made from the wikitext editor are marked as bot if user is in proper group IIRC, so it only makes sense to make visual editor behave in the same way -- but that's not my call to decide.

I hope this makes sense.

@Urbanecm Sure, Please fix catalot gadget, but just for those users who has flood flag. Otherwise, the edits should not be marked as bot for those users who has not flood flag. I think it should be fixed also in Visual Editor like Wikitext Editor. Thanks!

@Urbanecm Sure, Please fix catalot gadget, but just for those users who has flood flag. Otherwise, the edits should not be marked as bot for those users who has not flood flag. I think it should be fixed also in Visual Editor like Wikitext Editor. Thanks!

Done.

ppelberg added a project: Editing-team.
ppelberg moved this task from Untriaged to Next Quarter on the Editing-team board.