| ExE-Boss | |
| Jun 13 2021, 7:48 PM |
| F34951941: image.png | |
| Feb 15 2022, 5:28 AM |
Currently, the CodeMirror extension only highlights the <languages /> and <translate> tags, but not the new <tvar name=n>...</tvar> tag syntax.
Support for highlighting the <translate> tag was added in T172456: Syntax highlighting - translate and tvar tags, and the new <tvar> syntax was introduced to Extension:Translate in T274881: Change translation variable (tvar) syntax, but CodeMirror still shows them unstyled.
Note that <tvar> tags are only valid inside the <translate> tags.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | kaldari | T101246 Highlighted wikisyntax while editing articles [AOI] | |||
| Resolved | MaxSem | T185030 Graduate Syntax Highlighting (CodeMirror) out of beta for non-RTL wikis on the 2010 wikitext editor | |||
| Resolved | MusikAnimal | T172456 Syntax highlighting - translate and tvar tags | |||
| Resolved | Feature | AntiCompositeNumber | T284883 CodeMirror – support highlighting the new <tvar> tag syntax | ||
| Resolved | Nikerabbit | T274881 Change translation variable (tvar) syntax |
The problem mentioned in T172456#4024855 still applies. Adding support for <tvar name="1"></tvar> is fairly easy, it would just be defined as another HTML tag (since Translate doesn't register it as a parser tag). However, highlighting will break on pages that use <tvar|1></> syntax. It doesn't break horribly, but it treats the <tvar|1> tag as unclosed.
So, what needs to be done is to add tvar to the list like in rECMI980f3d28480c: Add <translate> as a permitted tag?
Change 763585 had a related patch set uploaded (by AntiCompositeNumber; author: AntiCompositeNumber):
[mediawiki/extensions/CodeMirror@master] Add <tvar> to list of HTML tags
Change 763918 had a related patch set uploaded (by AntiCompositeNumber; author: AntiCompositeNumber):
[mediawiki/extensions/Translate@master] Add CodeMirror configuration
Sorry for the wait. Moving this to the Community Tech sprint board so we can prioritize code review.
Is it possible to only highlight those tags related to translation on a site with Extension:Translate installed? If it is impossible to actually mark a page for translation, it is useless to highlight those tags.
Yes, and that was the concern with the initial approach here and with your patch. The new patches are supposed to address this, once we get around to code review (please feel free to help :). I hope to look at this today/tomorrow if no one beats me to it.
Change 763918 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Add CodeMirror configuration
Change 763585 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Add tags from CodeMirrorPluginModules to extension tags list
This works fine, expect in link target, where they are mainly used. CodeMirror should also parse link targets to look for tvar tag:
@Pols12, could you create two new tasks for that? I personally don't consider the first to be a bug though.