Page MenuHomePhabricator

homepage_discovery tour shows popup in the bad position when the skin doesn't display #pt-userpage element initially
Open, Needs TriagePublicBUG REPORT

Description

List of steps to reproduce

  • Login to any wiki which enables homepage_discovery tour by default. For instance, kowiki.
  • Set your skin to 'minerva' or 'timeless'.
  • Execute new mw.Api().saveOption( 'growthexperiments-tour-homepage-discovery', '0' ); in your browser console.
  • Refresh the page

Or

What happens?:

The popup for the first step of the tour is floating in an arbitrary position and the anchor is gone.

image.png (515×550 px, 35 KB)

What should have happened instead?:

idk, an anchored popup could be shown? but where to point?

Anyway, the next picture describes the normal behavior in modern Vector.

image.png (402×799 px, 48 KB)

Event Timeline

Restricted Application added subscribers: Masumrezarock100, revi, Aklapper. · View Herald Transcript
Lens0021 renamed this task from homepage_discovery tour shows popup in the bad position when the skin has no #pt-userpage element to homepage_discovery tour shows popup in the bad position when the skin doesn't display #pt-userpage element initially.EditedJun 14 2021, 9:47 AM

In https://en.wikipedia.beta.wmflabs.org/, the new user links of modern Vector also don't seem to have #pt-userpage.

kostajh added subscribers: Etonkovidova, kostajh.

@Lens0021 thanks for filing this. Indeed, we focus on Vector (specifically new Vector as that is what new accounts get by default) and Minerva, and for Minerva we code specifically for the case when OO.ui.isMobile() is true.

@Etonkovidova could you please verify if this is a problem in modern Vector?

@Lens0021 thanks for filing this. Indeed, we focus on Vector (specifically new Vector as that is what new accounts get by default) and Minerva, and for Minerva we code specifically for the case when OO.ui.isMobile() is true.

@Etonkovidova could you please verify if this is a problem in modern Vector?

The issue is not present in Vector (or in Legacy Vector). MonoBook looks fine, though there might be some improvement.

Vector (default)Monobook
Screen Shot 2021-06-23 at 4.51.17 PM.png (764×1 px, 216 KB)
Screen Shot 2021-06-23 at 4.57.47 PM.png (570×1 px, 96 KB)

The issue is present in Minerva Neue, Timeless, and Modern skins.

Minerva NeueTimelessModern
Screen Shot 2021-06-23 at 4.57.03 PM.png (1×2 px, 171 KB)
Screen Shot 2021-06-23 at 4.51.52 PM.png (1×2 px, 223 KB)
Screen Shot 2021-06-23 at 4.58.41 PM.png (658×1 px, 136 KB)

This is the same issue as T287646: New user links: Guided tours displayed incorrectly, except that one was for Vector. Minerva and Timeless also use dropdowns so we run into the same issue. (Modern does work, the guider positioning is just not very good and so the tip is far enough from the userpage link to make interpreting it non-obvious. This is a generic problem with GuidedTours guiders.)

I don't know if we want to special-case each of these skins, this seems like something that should be handled on the skin level, maybe with an abstraction similar to mw.util.isPortletVisible() which allows locating the closest visible parent of a given portlet item.

In an case for GrowthExperiments this is not a big issue IMO - the guiders are shown shortly after registration and it's unlikely that the user would have switched to a non-default skin by that point.