Page MenuHomePhabricator

Localize numbers and currency
Closed, ResolvedPublic1 Estimated Story Points

Description

There are some places in which we use German localized notation of dates and numbers. We should apply English notation to the English language version of the application.

Acceptance Criteria

  • The format for numbers/currencies in English is:
    • The currency symbol is put in front.
    • The digit grouping character is ,.
    • The decimal separator is ..
  • The format for numbers/currencies in German is:
    • The currency symbol is at the end.
    • The digit grouping character is ..
    • The decimal separator is ,.
  • When the application is set to display content in English,
    • the amount options in the donation and membership application forms are localized.
    • the custom amount field is localized.
    • the summary boxes in the donation and membership forms and on the confirmation pages are localized.
    • the payment amount in the confirmation mails is localized.
    • the donation amounts in the list of comments are localized (currently, this is a localization mix).
    • the donation amounts in the Hall of Fame are localized. (These come straight from a file in content)
    • the revenue amounts and the donation target on the use of funds page are localized. (These come straight from a file in content)

Event Timeline

More specification needed:

  • where do changes need to happen?
  • which format should be used?
  • what about the academic titles?
kai.nissen renamed this task from Localize dates, numbers and currency to Localize numbers and currency.Jul 1 2021, 1:31 PM
kai.nissen updated the task description. (Show Details)
kai.nissen set the point value for this task to 8.
AbbanWMDE updated the task description. (Show Details)
AbbanWMDE moved this task from Doing to Review on the WMDE-FUN-Sprint-2021-07-05 board.
AbbanWMDE subscribed.

PRs:

I have user-tested the English numbers (embedded into the German text) and they looked OK. We need to wait for the English translations to the emails to test them.

The frontend changes + content changes should be deployed to a test server for further user testing

gabriel-wmde changed the point value for this task from 8 to 1.

@AbbanWMDE Where can I find these changes? deployments.json doesn't give me a hint.

I looked at the application on test-spenden-2.wikimedia.de. Looks all good to me.