Page MenuHomePhabricator

TwoColConflict (still) deletes empty lines
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

We worked on this issue already, see T250262: Empty line differences confuse TwoColConflict UI. However, the patch https://gerrit.wikimedia.org/r/592607 left a bogus edge-case behind: When a user does nothing but increasing the number of linebreaks, there was a chance these linebreaks get lost.

Reported by a user: https://www.mediawiki.org/wiki/Topic:Wavepm145vjst1n9

Event Timeline

Change 699935 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TwoColConflict@master] Fix newline handling when adding nothing but newlines

https://gerrit.wikimedia.org/r/699935

thiemowmde set the point value for this task to 2.

Change 699935 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] Fix newline handling when adding nothing but newlines

https://gerrit.wikimedia.org/r/699935

Yes, the linked patch is merged and live. Thanks for the reminder!