Page MenuHomePhabricator

Backport some changes from REL1_36 to REL1_35
Closed, DeclinedPublic

Description

There are some changes in
https://github.com/wikimedia/mediawiki-extensions-ApprovedRevs/blob/REL1_36/includes/ApprovedRevs.php
that should be ported to
https://github.com/wikimedia/mediawiki-extensions-ApprovedRevs/blob/REL1_35/includes/ApprovedRevs.php#L381 .
Those changes shouldn't break anything since the logic covers 3 cases depending on the state of actor/revision tables.
Looking at https://www.mediawiki.org/wiki/Release_notes/1.35 we see "revision.rev_user and rev_user_text, replaced by rev_actor referencing actor.actor_id." . This means that the line in question will result in an error, because rev_user_text column is removed.

Event Timeline

Aklapper renamed this task from Changes from REL1_36 not ported to REL1_35 to Backport some changes from REL1_36 to REL1_35.Jun 16 2021, 11:06 AM
Yaron_Koren subscribed.

This presumably no longer matters - sorry that it was never done.