Page MenuHomePhabricator

Unable to delete files on betacommons
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

[YMxIldLueIuvb-v7dLemCQAAAAk] /w/index.php?title=File:Testing_image_2.jpg&action=delete TypeError: Argument 5 passed to FileDeleteForm::__construct() must be an instance of MediaWiki\Watchlist\WatchlistManager, null given, called in /srv/mediawiki/php-master/includes/page/ImagePage.php on line 1010

Backtrace:

from /srv/mediawiki/php-master/includes/FileDeleteForm.php(78)
#0 /srv/mediawiki/php-master/includes/page/ImagePage.php(1010): FileDeleteForm->__construct(LocalFile, RequestContext, ReadOnlyMode, RepoGroup, NULL, MediaWiki\Linker\LinkRenderer, MediaWiki\User\UserOptionsManager)
#1 /srv/mediawiki/php-master/includes/actions/DeleteAction.php(41): ImagePage->delete()
#2 /srv/mediawiki/php-master/includes/MediaWiki.php(536): DeleteAction->show()
#3 /srv/mediawiki/php-master/includes/MediaWiki.php(320): MediaWiki->performAction(ImagePage, Title)
#4 /srv/mediawiki/php-master/includes/MediaWiki.php(917): MediaWiki->performRequest()
#5 /srv/mediawiki/php-master/includes/MediaWiki.php(551): MediaWiki->main()
#6 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#7 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#8 /srv/mediawiki/w/index.php(3): require(string)
#9 {main}

What should have happened instead?:
Deleted copyvio should have happened

I can't test this on betaenwiki etc because I don't have admin privileges there. Creating a page and uploading a file worked as usual, only deletion seems to be an issue.

Details

Related Objects

StatusSubtypeAssignedTask
ResolvedReleasedduvall
ResolvedBUG REPORTZabe

Event Timeline

Zabe triaged this task as Unbreak Now! priority.
Zabe added a project: User-Zabe.
Zabe subscribed.

Change 700355 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Stop calling private Article::$watchlistManager

https://gerrit.wikimedia.org/r/700355

Deprecated: Accessing Article::$watchlistManager is deprecated since MediaWiki 1.35 [Called from ImagePage::delete in /srv/patchdemo-wikis/8c7894bebc/w/includes/page/ImagePage.php at line 1008] in /srv/patchdemo-wikis/8c7894bebc/w/includes/debug/MWDebug.php on line 376

Notice: Inaccessible property via __get(): watchlistManager in /srv/patchdemo-wikis/8c7894bebc/w/includes/page/Article.php on line 2358

Change 700355 merged by jenkins-bot:

[mediawiki/core@master] Stop calling private Article::$watchlistManager

https://gerrit.wikimedia.org/r/700355