Page MenuHomePhabricator

Schema change for dropping rev_page_id index
Closed, ResolvedPublic

Description

Context: T163532: Drop index rev_page_id (rev_page, rev_id)

  1. ALTERs to run: alter table revision drop key rev_page_id; (from https://gerrit.wikimedia.org/r/692630)
  2. Where to run those changes: all.dblist
  3. When to run those changes: At any time
  4. If the schema change is backwards compatible: Yes
  5. If the schema change has been tested already on some of the test/beta wikis: Tested in production. See the ticket.
  6. if the data should be made available on the labs replicas and/or dumps: Does it matter? This table is public AFAIK

Note that given that we have rev_page_time index, this possibly can't be much slower ignoring code and the data and given the data, there shouldn't be any noticeable change.

Progress:

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Mentioned in SAL (#wikimedia-operations) [2022-01-26T07:23:18Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1163 (T285149)', diff saved to https://phabricator.wikimedia.org/P19238 and previous config saved to /var/cache/conftool/dbconfig/20220126-072317-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T08:08:32Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1163 (T285149)', diff saved to https://phabricator.wikimedia.org/P19241 and previous config saved to /var/cache/conftool/dbconfig/20220126-080831-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T08:08:45Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1134 (T285149)', diff saved to https://phabricator.wikimedia.org/P19242 and previous config saved to /var/cache/conftool/dbconfig/20220126-080842-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T08:09:49Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1134 (T285149)', diff saved to https://phabricator.wikimedia.org/P19243 and previous config saved to /var/cache/conftool/dbconfig/20220126-080948-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T08:55:03Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1134 (T285149)', diff saved to https://phabricator.wikimedia.org/P19246 and previous config saved to /var/cache/conftool/dbconfig/20220126-085503-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T08:55:12Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1135 (T285149)', diff saved to https://phabricator.wikimedia.org/P19247 and previous config saved to /var/cache/conftool/dbconfig/20220126-085510-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T08:56:17Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1135 (T285149)', diff saved to https://phabricator.wikimedia.org/P19248 and previous config saved to /var/cache/conftool/dbconfig/20220126-085616-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T09:41:31Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1135 (T285149)', diff saved to https://phabricator.wikimedia.org/P19255 and previous config saved to /var/cache/conftool/dbconfig/20220126-094131-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T09:41:41Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1099:3311 (T285149)', diff saved to https://phabricator.wikimedia.org/P19256 and previous config saved to /var/cache/conftool/dbconfig/20220126-094138-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T09:42:45Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1099:3311 (T285149)', diff saved to https://phabricator.wikimedia.org/P19257 and previous config saved to /var/cache/conftool/dbconfig/20220126-094244-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T10:27:58Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1099:3311 (T285149)', diff saved to https://phabricator.wikimedia.org/P19265 and previous config saved to /var/cache/conftool/dbconfig/20220126-102758-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T10:28:11Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1184 (T285149)', diff saved to https://phabricator.wikimedia.org/P19266 and previous config saved to /var/cache/conftool/dbconfig/20220126-102805-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T10:29:12Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1184 (T285149)', diff saved to https://phabricator.wikimedia.org/P19267 and previous config saved to /var/cache/conftool/dbconfig/20220126-102911-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T11:14:26Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1184 (T285149)', diff saved to https://phabricator.wikimedia.org/P19275 and previous config saved to /var/cache/conftool/dbconfig/20220126-111425-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T11:15:04Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1106 (T285149)', diff saved to https://phabricator.wikimedia.org/P19276 and previous config saved to /var/cache/conftool/dbconfig/20220126-111504-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T11:16:10Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1106 (T285149)', diff saved to https://phabricator.wikimedia.org/P19277 and previous config saved to /var/cache/conftool/dbconfig/20220126-111610-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T12:01:25Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1106 (T285149)', diff saved to https://phabricator.wikimedia.org/P19290 and previous config saved to /var/cache/conftool/dbconfig/20220126-120125-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T12:01:35Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1119 (T285149)', diff saved to https://phabricator.wikimedia.org/P19291 and previous config saved to /var/cache/conftool/dbconfig/20220126-120132-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T12:04:39Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1119 (T285149)', diff saved to https://phabricator.wikimedia.org/P19292 and previous config saved to /var/cache/conftool/dbconfig/20220126-120439-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T12:49:54Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1119 (T285149)', diff saved to https://phabricator.wikimedia.org/P19303 and previous config saved to /var/cache/conftool/dbconfig/20220126-124953-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T12:50:04Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1105:3311 (T285149)', diff saved to https://phabricator.wikimedia.org/P19304 and previous config saved to /var/cache/conftool/dbconfig/20220126-125001-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T12:51:07Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1105:3311 (T285149)', diff saved to https://phabricator.wikimedia.org/P19306 and previous config saved to /var/cache/conftool/dbconfig/20220126-125107-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T13:36:28Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1105:3311 (T285149)', diff saved to https://phabricator.wikimedia.org/P19318 and previous config saved to /var/cache/conftool/dbconfig/20220126-133627-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T13:36:36Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1164 (T285149)', diff saved to https://phabricator.wikimedia.org/P19319 and previous config saved to /var/cache/conftool/dbconfig/20220126-133634-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-26T13:37:41Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1164 (T285149)', diff saved to https://phabricator.wikimedia.org/P19320 and previous config saved to /var/cache/conftool/dbconfig/20220126-133740-marostegui.json

s1 replicas done. Once all of them are repooled, I will do the primary master.

Mentioned in SAL (#wikimedia-operations) [2022-01-26T14:23:01Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1164 (T285149)', diff saved to https://phabricator.wikimedia.org/P19331 and previous config saved to /var/cache/conftool/dbconfig/20220126-142255-marostegui.json

First attempt running this on s1 master wasn't a success. Impossible to get the metadata, will try again a few more times.

Mentioned in SAL (#wikimedia-operations) [2022-01-27T07:04:29Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1123 (T285149)', diff saved to https://phabricator.wikimedia.org/P19378 and previous config saved to /var/cache/conftool/dbconfig/20220127-070428-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-27T07:13:55Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1123 (T285149)', diff saved to https://phabricator.wikimedia.org/P19383 and previous config saved to /var/cache/conftool/dbconfig/20220127-071355-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-27T07:59:09Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1123 (T285149)', diff saved to https://phabricator.wikimedia.org/P19392 and previous config saved to /var/cache/conftool/dbconfig/20220127-075909-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-27T08:16:23Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1112 (T285149)', diff saved to https://phabricator.wikimedia.org/P19395 and previous config saved to /var/cache/conftool/dbconfig/20220127-081622-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-27T09:16:42Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1112 (T285149)', diff saved to https://phabricator.wikimedia.org/P19408 and previous config saved to /var/cache/conftool/dbconfig/20220127-091641-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-27T10:01:56Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1112 (T285149)', diff saved to https://phabricator.wikimedia.org/P19419 and previous config saved to /var/cache/conftool/dbconfig/20220127-100155-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-27T10:20:50Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1166 (T285149)', diff saved to https://phabricator.wikimedia.org/P19422 and previous config saved to /var/cache/conftool/dbconfig/20220127-102049-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-27T10:46:19Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1166 (T285149)', diff saved to https://phabricator.wikimedia.org/P19424 and previous config saved to /var/cache/conftool/dbconfig/20220127-104618-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-27T11:31:33Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1166 (T285149)', diff saved to https://phabricator.wikimedia.org/P19435 and previous config saved to /var/cache/conftool/dbconfig/20220127-113132-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-27T11:31:42Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1179 (T285149)', diff saved to https://phabricator.wikimedia.org/P19436 and previous config saved to /var/cache/conftool/dbconfig/20220127-113140-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-27T13:26:25Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1112 (T285149)', diff saved to https://phabricator.wikimedia.org/P19460 and previous config saved to /var/cache/conftool/dbconfig/20220127-132624-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-27T13:36:53Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1112 (T285149)', diff saved to https://phabricator.wikimedia.org/P19463 and previous config saved to /var/cache/conftool/dbconfig/20220127-133652-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-27T14:22:07Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1112 (T285149)', diff saved to https://phabricator.wikimedia.org/P19473 and previous config saved to /var/cache/conftool/dbconfig/20220127-142206-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-27T14:22:17Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1175 (T285149)', diff saved to https://phabricator.wikimedia.org/P19474 and previous config saved to /var/cache/conftool/dbconfig/20220127-142214-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-27T15:22:35Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1175 (T285149)', diff saved to https://phabricator.wikimedia.org/P19486 and previous config saved to /var/cache/conftool/dbconfig/20220127-152235-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-27T16:07:49Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1175 (T285149)', diff saved to https://phabricator.wikimedia.org/P19492 and previous config saved to /var/cache/conftool/dbconfig/20220127-160749-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-27T18:16:57Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1175 (T285149)', diff saved to https://phabricator.wikimedia.org/P19507 and previous config saved to /var/cache/conftool/dbconfig/20220127-181656-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-27T18:26:28Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1175 (T285149)', diff saved to https://phabricator.wikimedia.org/P19509 and previous config saved to /var/cache/conftool/dbconfig/20220127-182627-marostegui.json

s3 replicas done, I will do the primary master on Monday.

Mentioned in SAL (#wikimedia-operations) [2022-01-27T19:11:42Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1175 (T285149)', diff saved to https://phabricator.wikimedia.org/P19517 and previous config saved to /var/cache/conftool/dbconfig/20220127-191141-marostegui.json

s3 replicas done, I will do the primary master on Monday.

I have finally decided to do s3 master now.
This is all done!