Page MenuHomePhabricator

[WMAU skin] Allow wiki files to be used as menu icons
Closed, ResolvedPublic

Description

Currently, the icon parameter in the menu configuration must be the name of a bundled icon (from Feathericons). It'd be better if it could accept any image that's been uploaded to the wiki.

This could be backwards compatible, but perhaps it's better/simpler to remove the icons from the skin (other than search, which is used for the search popup in the top menu).

Event Timeline

Menu icons are no longer required. The existing ones have been removed (other than search).

Samwilson added a subscriber: Jimmyjrg.

Re-opening after discussion with @Jimmyjrg about needing social media icons in the footer.

Sounds good. Those are the same icons that are in https://commons.wikimedia.org/wiki/Category:Simplicon_Interface_icons aren't they? So if we solve for allowing any local or Commons file to be used, then you could upload those to Commons and use them from there? (I think they're all PD, so that's allowed.)

Also, just to confirm: the icon would replace the text label wouldn't it? Not appear alongside? The text label would appear as a tooltip.

Yes, it looks like they're the same. They have the same author. The Github link has a license file that says the icons are all CC0 1.0 Universal.

Yes, the icons would replace the text. Thank you.

Change 924368 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/skins/WMAU@master] Allow 'icon' menu config to refer to a wiki file

https://gerrit.wikimedia.org/r/924368

Change 924368 merged by jenkins-bot:

[mediawiki/skins/WMAU@master] Allow 'icon' menu config to refer to a wiki file

https://gerrit.wikimedia.org/r/924368

Samwilson claimed this task.

This is now done, and the work released in version 0.6.0 of the skin, and deployed to wikimedia.org.au. I've set the Mastodon logo in the footer of the site, and others can be set as required.

Change 933217 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/skins/WMAU@master] Fix vertical alignment of menu icons

https://gerrit.wikimedia.org/r/933217

Change 933217 merged by jenkins-bot:

[mediawiki/skins/WMAU@master] Fix vertical alignment of menu icons

https://gerrit.wikimedia.org/r/933217