Page MenuHomePhabricator

ProofreadPage: allow access to index fields config item (e.g. prpPageNumber) in edit mode
Closed, ResolvedPublic


Properties of Page NS pages that can be accessed with the prp... prefix in mw.config are inconsistently available:

  • prpPageQualityUser is only set in edit mode
  • prpPageQuality and prpPageNumber are only set in "rendered" modes (i.e. view and submit)

This means that gadgets looking for this information will not work consistently during the edit flow. For example, a script that uses prpPageNumber will work in view, not in edit and will work again in submit.

I think all the properties should always be available, edit or not.

Event Timeline

Yeah, this needs to be fixed and consistently added both in edit mode and view/submit mode. We might also want to refactor some of the existing code and add a dedicated function to deal with adding all the config variables inside PageDisplayHandler.php.

Change 739852 had a related patch set uploaded (by Inductiveload; author: Inductiveload):

[mediawiki/extensions/ProofreadPage@master] Set all JS vars in view, edit and submit modes

Change 739852 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Set all JS vars in view, edit and submit modes

This is now working well at enWS.