View an item containing a statement using a local property when federation is enabled
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	• Samantha_Alipio_WMDE
	Jun 22 2021, 7:49 AM

Description

As a Wikibase reader in a wiki with Federated Properties v2 enabled, I want to be able to view statements on my local entities that were made with local properties.

Currently, when a statement is added containing a local property, it is saved but cannot be re-rendered.

BDD Scenario: On an item page in a Wikibase with Federated Properties enabled
GIVEN I have added a statement to a local item using a local property
WHEN I load the item page
THEN The page is rendered successfully
AND I can view the statements made on the item

Note:
It is surprising that this very core feature of Wikibase, saving statements using local properties on local entities, is broken and did not result in any tests failing. Therefore, there is likely some additional testing complexity involved in making sure that this does not happen again.

Note: this issue would theoretically apply to any "entity" but in this story we are focused on item pages only.

Details

	Subject	Repo	Branch	Lines +/-
	FP: Prefetch only federated properties in FederatedPropertiesEntityParserOutputGenerator	mediawiki/extensions/Wikibase	master	+10 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T285291 [EPIC] Manually add statements about local items using either local or federated property
		Resolved		• Tonina_Zhelyazkova_WMDE	T285293 View an item containing a statement using a local property when federation is enabled

Event Timeline

• Samantha_Alipio_WMDE created this task.Jun 22 2021, 7:49 AM

As far as I know saving currently works fine:
e.g. from the test system:

{"entities":{"Q2":{"pageid":5,"ns":120,"title":"Item:Q2","lastrevid":7,"modified":"2021-08-11T08:10:30Z","type":"item","id":"Q2","labels":{"en":{"language":"en","value":"foo cat"}},"descriptions":{},"aliases":{},"claims":{"P1":[{"mainsnak":{"snaktype":"value","property":"P1","hash":"874d19e6a8080831f530365565a57dc9dd3ba463","datavalue":{"value":"cat","type":"string"},"datatype":"string"},"type":"statement","id":"Q2$158446eb-4a66-c356-6a79-3cd1e66bf622","rank":"normal"}]},"sitelinks":{}}}}

however right now these pages cannot subsequently be rerendered.

We might also want to write some test cases to ensure that this functionality continues.

• Samantha_Alipio_WMDE renamed this task from Save a statement with a local property when federation is enabled to View a saved statement containing a local property when federation is enabled.Aug 11 2021, 8:27 AM

• Samantha_Alipio_WMDE updated the task description. (Show Details)

Tarrow updated the task description. (Show Details)Aug 11 2021, 8:28 AM

Tarrow mentioned this in T288601: Save local statements on local items while federated properties are enabled.Aug 11 2021, 8:33 AM

• Samantha_Alipio_WMDE moved this task from Backlog to Ready for story writing on the Wikibase - Federated Properties board.Aug 11 2021, 8:36 AM

Tarrow renamed this task from View a saved statement containing a local property when federation is enabled to View an entity containing a statement using a local property when federation is enabled.Aug 11 2021, 8:36 AM

• Samantha_Alipio_WMDE updated the task description. (Show Details)Aug 11 2021, 9:01 AM

• Samantha_Alipio_WMDE moved this task from Ready for story writing to Ready to estimate on the Wikibase - Federated Properties board.Aug 11 2021, 9:04 AM

Tarrow mentioned this in T288597: Re-enable editing of local properties via the entity page when federated properties are enabled.Aug 11 2021, 9:28 AM

• Samantha_Alipio_WMDE updated the task description. (Show Details)Aug 11 2021, 12:34 PM

• Samantha_Alipio_WMDE set the point value for this task to 8.

• Samantha_Alipio_WMDE moved this task from Ready to estimate to Ready for Breakdown on the Wikibase - Federated Properties board.

• Samantha_Alipio_WMDE triaged this task as High priority.Aug 18 2021, 9:29 AM

• Samantha_Alipio_WMDE moved this task from Ready for Breakdown to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.Aug 18 2021, 9:35 AM

• Samantha_Alipio_WMDE moved this task from Prioritized backlog (aka Ready to pick up) to Federation v2 - Sprint 5 on the Wikibase - Federated Properties board.

• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties (Federation v2 - Sprint 5); removed Wikibase - Federated Properties.

• Samantha_Alipio_WMDE renamed this task from View an entity containing a statement using a local property when federation is enabled to View an item containing a statement using a local property when federation is enabled.Aug 18 2021, 9:55 AM

• Samantha_Alipio_WMDE updated the task description. (Show Details)

Task breakdown notes:

Start at extensions/Wikibase/repo/includes/FederatedProperties/FederatedPropertiesEntityParserOutputGenerator.php
Consider if we should introduce a new method to build a list of just FederatedPropertyIDs and only prefetch those
- We could build this by iterating over the PropertyIds and passing them to a EntitySourceLookup and then checking the source type (or have a method in URIPropertyId and NumericPropertyId that returns the type of source)
Write a test to ensure an error like this doesn't happen again

Alternatively we might want to consider if we want to have a separate FederatedPropertiesEntityParserOutputGenerator and instead put the logic in some part of the FullEntityParserOutputGenerator

Just solving this might not be sufficient to make this work.

• Tonina_Zhelyazkova_WMDE claimed this task.Aug 19 2021, 12:43 PM

• Tonina_Zhelyazkova_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 5) board.

Change 714019 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] FP: Prefetch only federated properties in FederatedPropertiesEntityParserOutputGenerator

https://gerrit.wikimedia.org/r/714019

gerritbot added a project: Patch-For-Review.Aug 20 2021, 9:30 AM

• Tonina_Zhelyazkova_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 5) board.Aug 25 2021, 10:18 AM

Change 714019 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Prefetch only federated properties in FederatedPropertiesEntityParserOutputGenerator

https://gerrit.wikimedia.org/r/714019

Maintenance_bot removed a project: Patch-For-Review.Aug 26 2021, 10:10 AM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.21; 2021-08-30).Aug 26 2021, 11:00 AM

Tarrow moved this task from Peer Review to Done on the Wikibase - Federated Properties (Federation v2 - Sprint 5) board.Aug 26 2021, 11:03 AM

To verify take a look at https://wikidata-federated-properties.wmflabs.org/wiki/Item:Q3 which contains a statement with a local property. The page renders normally and no error is shown like the one in the task description.

• Tonina_Zhelyazkova_WMDE moved this task from Done to Product Verification on the Wikibase - Federated Properties (Federation v2 - Sprint 5) board.Aug 26 2021, 1:52 PM

Verified

T289667 fell out of the solution for this

Tarrow closed this task as Resolved.Sep 1 2021, 9:28 AM

	F34590217: image.png
	Aug 11 2021, 8:28 AM

View an item containing a statement using a local property when federation is enabledClosed, ResolvedPublic8 Estimated Story PointsActions

Description

Details

Related ObjectsSearch...

Event Timeline

View an item containing a statement using a local property when federation is enabled
Closed, ResolvedPublic8 Estimated Story Points
Actions

Related Objects
Search...