Page MenuHomePhabricator

Make all httpbb tests pass on the mwdebug deployment.
Closed, ResolvedPublic

Description

We have a battery of tests for httpbb that we run to validate as a smoke-test the validity of one installation of our apache configurations.

We want all of those tests to pass, before we move on to further stages of functional testing.

The first hurdle is that some of those tests are supposed to go to http (for no good reason I'd say) and thus fail completely on the k8s installations that are https only.

Failing tests after removing the http-only ones, or converting them:

Event Timeline

Joe triaged this task as High priority.
Joe created this task.

On second thoughts: we're mostly using http where we could just use:

request_headers:
  X-Forwarded-Proto: http

instead. I'll do that where appropriate.

Change 700856 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[operations/puppet@production] httpbb: move most tests to https

https://gerrit.wikimedia.org/r/700856

Change 700856 merged by Giuseppe Lavagetto:

[operations/puppet@production] httpbb: move most tests to https

https://gerrit.wikimedia.org/r/700856

Change 708789 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[operations/puppet@production] mediawiki::website: parametrize the fcgi proxy in search.w.o

https://gerrit.wikimedia.org/r/708789

Change 708789 merged by Giuseppe Lavagetto:

[operations/puppet@production] mediawiki::website: parametrize the fcgi proxy in all sites

https://gerrit.wikimedia.org/r/708789

Change 713488 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[operations/puppet@production] httpbb: Add check for https://en.wikipedia.org/favicon.ico

https://gerrit.wikimedia.org/r/713488

Change 713488 merged by RLazarus:

[operations/puppet@production] httpbb: Add check for https://en.wikipedia.org/favicon.ico

https://gerrit.wikimedia.org/r/713488

dancy added a subscriber: dancy.

Change 720817 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[operations/puppet@production] Add tests to exercise uses of the php symlink in operations/mediawiki-config

https://gerrit.wikimedia.org/r/720817

Change 720817 merged by Alexandros Kosiaris:

[operations/puppet@production] Add tests to exercise uses of the php symlink in operations/mediawiki-config

https://gerrit.wikimedia.org/r/720817

Change 732280 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[operations/puppet@production] httpbb: change headers test for /static/current

https://gerrit.wikimedia.org/r/732280

Change 732280 merged by Giuseppe Lavagetto:

[operations/puppet@production] httpbb: change headers test for /static/current

https://gerrit.wikimedia.org/r/732280

Right now we have just 3 tests not passing:

So I am inclined to close this task for now. I'll discuss removing those tests with relevant people, and if they think those tests should stay, we'll find a way to fix them.

Change 755529 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[operations/puppet@production] httpbb: remove tests that fail under k8s

https://gerrit.wikimedia.org/r/755529