Make all httpbb tests pass on the mwdebug deployment.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Joe
	Jun 22 2021, 8:02 AM

Description

We have a battery of tests for httpbb that we run to validate as a smoke-test the validity of one installation of our apache configurations.

We want all of those tests to pass, before we move on to further stages of functional testing.

The first hurdle is that some of those tests are supposed to go to http (for no good reason I'd say) and thus fail completely on the k8s installations that are https only.

Failing tests after removing the http-only ones, or converting them:

~~https://foundation.wikimedia.org/static/current/skins/Timeless/resources/print.css - Status code: expected 200, got 403.~~ T285232
https://en.wikipedia.org/favicon.ico - Status code: expected 200, got 500. T288848
~~https://search.wikimedia.org/?search=cthuluh - Status code: expected 200, got 503~~
~~https://www.wikiversity.org/ - Status code: expected 200, got 404.~~ T285325
~~https://donate.wikimedia.org/w/index.php?title=Special:LandingPage - Status code 500 - scribunto reports missing lua interpreter~~ T285309
~~https://species.wikimedia.org/wiki/Sitta_europaea_caesia - Status code 500 - scribunto reports missing lua interpreter~~ T285309
~~https://api.wikimedia.org/wiki/Main_Page - Status code: expected 200, got 500 - scribunto reports missing lua interpreter~~ T285309

Details

Subject	Repo	Branch	Lines +/-
httpbb: remove tests that fail under k8s	operations/puppet	production	+6 -11
httpbb: change headers test for /static/current	operations/puppet	production	+2 -2
Add tests to exercise uses of the php symlink in operations/mediawiki-config	operations/puppet	production	+15 -0
httpbb: Add check for https://en.wikipedia.org/favicon.ico	operations/puppet	production	+4 -0
mediawiki::website: parametrize the fcgi proxy in all sites	operations/puppet	production	+12 -7
httpbb: move most tests to https	operations/puppet	production	+8 -4

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Stalled	None	T255792 Quibble runs core:unit tests twice!
Open	None	T328919 Upgrade to PHPUnit 10
Open	None	T338103 Micro-optimize ApiResult::isMetadataKey with str_starts_with once we support PHP8+
Open	None	T328921 Drop PHP 7.4 support from MediaWiki
Stalled	None	T334726 Use return type `never` in Wikibase
Open	None	T328922 Drop PHP 8.0 support from MediaWiki
Stalled	None	T319055 Upgrade to psr/container 2.x
Stalled	Krinkle	T319432 Migrate WMF production from PHP 7.4 to PHP 8.1
Open	None	T291916 Tracking task for Bullseye migrations in production
Stalled	None	T356293 Migrate MW appservers' base images to bullseye
Open	None	T290536 Serve production traffic via Kubernetes
Resolved	Joe	T283056 Create a mwdebug deployment for mediawiki on kubernetes
Resolved	Joe	T285298 Make all httpbb tests pass on the mwdebug deployment.
Resolved	Joe	T285309 Install wiki-specific php extensions in the mediawiki production image
Resolved	jeena	T285325 Check out www-portals repo in the mediawiki-webserver and in the mediawiki-multiversion images
Resolved	Joe	T285232 The restricted/mediawiki-webserver image should include skins and resources

Event Timeline

Joe claimed this task.Jun 22 2021, 8:02 AM

Joe triaged this task as High priority.

Joe created this task.

On second thoughts: we're mostly using http where we could just use:

request_headers:
  X-Forwarded-Proto: http

instead. I'll do that where appropriate.

Change 700856 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[operations/puppet@production] httpbb: move most tests to https

https://gerrit.wikimedia.org/r/700856

gerritbot added a project: Patch-For-Review.Jun 22 2021, 9:18 AM

Joe updated the task description. (Show Details)Jun 22 2021, 10:10 AM

Joe updated the task description. (Show Details)Jun 22 2021, 12:47 PM

Change 700856 merged by Giuseppe Lavagetto:

[operations/puppet@production] httpbb: move most tests to https

https://gerrit.wikimedia.org/r/700856

Joe updated the task description. (Show Details)Jun 22 2021, 3:43 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 22 2021, 4:10 PM

Joe closed subtask T285309: Install wiki-specific php extensions in the mediawiki production image as Resolved.Jun 23 2021, 10:58 AM

Joe updated the task description. (Show Details)Jun 23 2021, 11:00 AM

Joe added a subtask: T285232: The restricted/mediawiki-webserver image should include skins and resources.Jun 28 2021, 9:43 AM

Joe moved this task from Backlog to Blocked on the MW-on-K8s board.Jun 28 2021, 9:45 AM

jeena closed subtask T285325: Check out www-portals repo in the mediawiki-webserver and in the mediawiki-multiversion images as Resolved.Jul 27 2021, 10:15 PM

Joe updated the task description. (Show Details)Jul 29 2021, 4:00 PM

Change 708789 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[operations/puppet@production] mediawiki::website: parametrize the fcgi proxy in search.w.o

https://gerrit.wikimedia.org/r/708789

gerritbot added a project: Patch-For-Review.Jul 29 2021, 4:07 PM

Change 708789 merged by Giuseppe Lavagetto:

[operations/puppet@production] mediawiki::website: parametrize the fcgi proxy in all sites

https://gerrit.wikimedia.org/r/708789

Maintenance_bot removed a project: Patch-For-Review.Aug 4 2021, 2:10 PM

Change 713488 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[operations/puppet@production] httpbb: Add check for https://en.wikipedia.org/favicon.ico

https://gerrit.wikimedia.org/r/713488

gerritbot added a project: Patch-For-Review.Aug 17 2021, 4:19 PM

Change 713488 merged by RLazarus:

[operations/puppet@production] httpbb: Add check for https://en.wikipedia.org/favicon.ico

https://gerrit.wikimedia.org/r/713488

Maintenance_bot removed a project: Patch-For-Review.Aug 17 2021, 6:10 PM

dancy updated the task description. (Show Details)Sep 13 2021, 6:08 PM

dancy subscribed.

Change 720817 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[operations/puppet@production] Add tests to exercise uses of the php symlink in operations/mediawiki-config

https://gerrit.wikimedia.org/r/720817

gerritbot added a project: Patch-For-Review.Sep 13 2021, 9:40 PM

Change 720817 merged by Alexandros Kosiaris:

[operations/puppet@production] Add tests to exercise uses of the php symlink in operations/mediawiki-config

https://gerrit.wikimedia.org/r/720817

Maintenance_bot removed a project: Patch-For-Review.Sep 14 2021, 6:10 AM

Joe moved this task from Blocked to In Progress on the MW-on-K8s board.Sep 20 2021, 8:13 AM

Joe closed subtask T285232: The restricted/mediawiki-webserver image should include skins and resources as Resolved.Oct 20 2021, 10:51 AM

Change 732280 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[operations/puppet@production] httpbb: change headers test for /static/current

https://gerrit.wikimedia.org/r/732280

gerritbot added a project: Patch-For-Review.Oct 20 2021, 10:51 AM

Joe reopened subtask T285232: The restricted/mediawiki-webserver image should include skins and resources as Open.Oct 20 2021, 11:27 AM

Change 732280 merged by Giuseppe Lavagetto:

[operations/puppet@production] httpbb: change headers test for /static/current

https://gerrit.wikimedia.org/r/732280

Maintenance_bot removed a project: Patch-For-Review.Oct 22 2021, 11:10 AM

Joe updated the task description. (Show Details)Dec 13 2021, 7:06 AM

Right now we have just 3 tests not passing:

the nonexistent test, which cannot work without an exposed http endpoint, so we don't really care.
https://en.wikipedia.org/static/current/resources/assets/licenses/README gets a 404, but I think we can live with that (and remove the test I guess?)
https://en.wikipedia.org/static/current/resources/Resources.php also returns a 404, which is actually a good thing - we didn't want people to access those php files anyways (we were testing for "not an entrypoint").

So I am inclined to close this task for now. I'll discuss removing those tests with relevant people, and if they think those tests should stay, we'll find a way to fix them.

Change 755529 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[operations/puppet@production] httpbb: remove tests that fail under k8s

https://gerrit.wikimedia.org/r/755529

gerritbot added a project: Patch-For-Review.Jan 20 2022, 7:59 AM

Change 755529 merged by Giuseppe Lavagetto:

[operations/puppet@production] httpbb: remove tests that fail under k8s

https://gerrit.wikimedia.org/r/755529

Joe closed subtask T285232: The restricted/mediawiki-webserver image should include skins and resources as Resolved.Feb 23 2022, 6:42 AM