|Update generated code for omnimail
|Add handling for extension tables without id
OK - I see the error
Error: Call to a member function getEntityFields() on null in Civi\Api4\Query\Api4SelectQuery->autoJoinFK() (line 970 of /srv/org.wikimedia.civicrm/civicrm/Civi/Api4/Query/Api4SelectQuery.php).
I'll dig into that
@EYener I just made the same update to that search that I did on live - see
By having an optional (LEFT) join & no WHERE clause you are not filtering the returned results at all. This is a bit of a confusion that people hit in the UI - the join criteria are the ON clause and not where - which is on the right
I should note this is a tricky UI issue - to improve usablity without losing the power of the engine - if you have any good ideas we can feed them back upstream
I have worked with Coleman to get a version of the patch I worked on (actually not really a version - something completely different he wrote :-) - and hence the upstreaming part is sorted.
I am putting this into review because there is an update to the generated code which we should merge before the next update when we adopt Coleman's patch
@EYener this should be correct now - we just need to merge https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/703492 & then we can close it
But also, be careful to specify that the join is 'Required' when joining on this table