mwgate-node12-docker consistently fails for EventLogging
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Gilles
	Jun 23 2021, 7:47 AM

Description

Example run: https://integration.wikimedia.org/ci/job/mwgate-node12-docker/4285/console
Affecte patch currently in review: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventLogging/+/700886

04:37:40 Running "eslint:all" (eslint) task
04:37:40 Warning: Failed to load plugin 'jsdoc' declared in '.eslintrc.json » eslint-config-wikimedia/client-es5 » ./client-common » ./common » ./jsdoc': Cannot find module 'eslint-plugin-jsdoc'
04:37:40 Require stack:
04:37:40 - /src/__placeholder__.js
04:37:40 Referenced from: /src/node_modules/eslint-config-wikimedia/jsdoc.json Use --force to continue.
04:37:40 
04:37:40 Aborted due to warnings.
04:37:40 npm ERR! code 6
04:37:40 npm ERR! path /src
04:37:40 npm ERR! command failed
04:37:40 npm ERR! command sh -c grunt test
04:37:40 
04:37:40 npm ERR! A complete log of this run can be found in:
04:37:40 npm ERR!     /cache/_logs/2021-06-23T02_37_40_104Z-debug.log

The same warning/error cannot be reproduced locally with npm ci && npm run-script test

Details

	Subject	Repo	Branch	Lines +/-
	build: Remove eventgate from package.json	mediawiki/extensions/EventLogging	master	+820 -3 K

Customize query in gerrit

Event Timeline

• Gilles created this task.Jun 23 2021, 7:47 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2021, 7:47 AM

• Gilles updated the task description. (Show Details)Jun 23 2021, 7:48 AM

Makes sense, we recently switched eventgate CI to using service-pipeline-test, because node12 and the version of node-rdkafka + librdkafka we use are not yet compatible.

We should probably switch eventlogging to use service-pipeline-test with blubber too.

Why would CI for this mediawiki extension need to install a kafka client? I thought this was just a side-effect of the package.json mixup.

Working around the issue with the pipeline woud imho mean declaring failure as that would also severely cripple the ability to run linters locally.

Hm, Ok I'm just guessing here, but maybe because @wikimedia/node-rdkafka-factory is an optionalDependency, and the CI doesn't run npm install --no-optional?

TBH I haven't actually investigated this here, I was just guessing since we encountered a CI problem when RelEng bumped the node version that eventgate was using.

Change 701157 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/EventLogging@master] build: Remove eventgate from package.json

https://gerrit.wikimedia.org/r/701157

gerritbot added a project: Patch-For-Review.Jun 23 2021, 4:49 PM

Change 701157 merged by Ottomata:

[mediawiki/extensions/EventLogging@master] build: Remove eventgate from package.json

https://gerrit.wikimedia.org/r/701157

Maintenance_bot removed a project: Patch-For-Review.Jun 24 2021, 2:10 PM

Krinkle closed this task as Resolved.Jun 24 2021, 10:37 PM

Krinkle claimed this task.

Krinkle edited projects, added Performance-Team, MediaWiki-extensions-EventLogging; removed Continuous-Integration-Infrastructure.

Krinkle added a subscriber: hashar.

Restricted Application added a project: Analytics. · View Herald TranscriptJun 24 2021, 10:37 PM

mwgate-node12-docker consistently fails for EventLoggingClosed, ResolvedPublicActions

Description

Details

Event Timeline

mwgate-node12-docker consistently fails for EventLogging
Closed, ResolvedPublic
Actions