Page MenuHomePhabricator
Create Task
Maniphest T285380

Update SMW to add support for MW 1.38
Closed, ResolvedPublic
Actions

Description

Using SMW with MW 1.38 results in various deprecation warnings. Some notices:

  1. Premature access to service container
  2. Avoid usage of deprecated ResourceLoaderTestModules
  3. Avoid usage of deprecated ParserCache::getETag

Details

SubjectRepoBranchLines +/-
Temporarily use SMW fork to apply fixes for MW 1.38translatewikimaster+7 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

abi_ triaged this task as Medium priority.Jun 23 2021, 10:23 AM
abi_ created this task.
abi_ moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2021-April-June) board.
abi_ added a comment.Jul 5 2021, 3:50 AM

I've submitted 4 patches to a fork of the repository to fix few issues.

The major remaining issues that I see,

  1. Use of the Revision class that was removed in MW 1.37 which was removed as part of work done in T247143
  2. Use of removed hooks - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/678414
    • NewRevisionFromEditComplete - use RevisionFromEditComplete
    • PageContentSaveComplete - use PageSaveComplete
    • TitleMoveComplete - use PageMoveComplete
Pginer-WMF edited projects, added Language-Team (Language-2021-July-September); removed Language-Team (Language-2021-April-June).Jul 12 2021, 8:18 AM
Pginer-WMF moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2021-July-September) board.
Nikerabbit added a comment.Jul 14 2021, 12:30 PM

https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues?q=is%3Aissue+is%3Aopen+deprecated lists bunch of things too.

Nikerabbit mentioned this in T281688: Unblock translatewiki.net deployments (removal of deprecated code which is still in use).Aug 25 2021, 10:25 AM
abi_ moved this task from In Progress to In Review on the Language-Team (Language-2021-July-September) board.Sep 14 2021, 3:04 PM
abi_ added a comment.Sep 15 2021, 5:04 PM
In T285380#7197001, @abi_ wrote:

I've submitted 4 patches to a fork of the repository to fix few issues.

The major remaining issues that I see,

  1. Use of the Revision class that was removed in MW 1.37 which was removed as part of work done in T247143
  2. Use of removed hooks - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/678414
    • NewRevisionFromEditComplete - use RevisionFromEditComplete
    • PageContentSaveComplete - use PageSaveComplete
    • TitleMoveComplete - use PageMoveComplete

These items are completed.

In T285380#7212016, @Nikerabbit wrote:

https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues?q=is%3Aissue+is%3Aopen+deprecated lists bunch of things too.

I'll go through these and see what else needs to be fixed. Some of these would have been fixed with my refactorings but have to check each one individually.

abi_ added a comment.EditedSep 17 2021, 7:11 AM
In T285380#7212016, @Nikerabbit wrote:

https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues?q=is%3Aissue+is%3Aopen+deprecated lists bunch of things too.

I've gone through the list and commented on issues that have been fixed. About 7 issues have been closed and 8 remain. In terms of issues that we may need to fix before we move to MW 1.37/1.38 on translatewiki.net,

  1. https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/5055
  2. https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/3851

We're currently testing this on a DEV setup of translatewiki.net, and plan to move this to translatewiki.net on 22nd Sept.

Moving this to recheck after deployment.

abi_ moved this task from In Review to Recheck after deployment on the Language-Team (Language-2021-July-September) board.Sep 17 2021, 7:12 AM
abi_ added a comment.Sep 29 2021, 12:17 PM

Translatewiki now runs code from SMW master branch. Next week we will be moving to MW 1.38.

Pginer-WMF edited projects, added Language-Team (Language-2021-October-December); removed Language-Team (Language-2021-July-September).Oct 1 2021, 12:31 PM
Pginer-WMF moved this task from Quarter Backlog to Recheck after deployment on the Language-Team (Language-2021-October-December) board.
abi_ added a comment.Oct 8 2021, 4:13 PM

SMW master + MW 1.37 was deployed on Translatewiki this Wednesday. We noticed issues which have been fixed in this PR: https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/5091

Next week we will be moving to MW 1.38 and we might see further issues that will be fixed in that PR or a different PR.

gerritbot added a comment.Oct 13 2021, 3:03 PM

Change 730543 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[translatewiki@master] Temporarily use SMW fork to apply fixes for MW 1.38

https://gerrit.wikimedia.org/r/730543

gerritbot added a project: Patch-For-Review.Oct 13 2021, 3:03 PM
abi_ renamed this task from Update SMW to add support for MW 1.37 to Update SMW to add support for MW 1.38.Oct 13 2021, 3:18 PM
abi_ updated the task description. (Show Details)

Translatewiki.net was updated to MW 1.38 today. Issues being noticed are being fixed here: https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/5100

gerritbot added a comment.Oct 13 2021, 4:34 PM

Change 730543 merged by jenkins-bot:

[translatewiki@master] Temporarily use SMW fork to apply fixes for MW 1.38

https://gerrit.wikimedia.org/r/730543

abi_ mentioned this in rGTWN4a84a5785d25: Temporarily use SMW fork to apply fixes for MW 1.38.Oct 13 2021, 4:37 PM
Nikerabbit added a subtask: T280760: PHP Deprecated: Use of Revision::getId/getUser was deprecated in MediaWiki 1.31. [Called from SMW\DataUpdater::addAnnotations].Oct 19 2021, 8:30 AM
Nikerabbit added a subtask: T280761: PHP Deprecated: Use of Revision::getContent was deprecated in MediaWiki 1.31. [Called from SMW\MediaWiki\EditInfo::fetchEditInfo.
abi_ changed the task status from Open to In Progress.Nov 16 2021, 6:15 PM
Nikerabbit added a subtask: T295883: "Allow $wgSettings to be used in LocalSettings.php" breaks SMW .Nov 17 2021, 1:53 PM
abi_ closed this task as Resolved.Nov 25 2021, 12:37 PM
abi_ moved this task from Recheck after deployment to Done on the Language-Team (Language-2021-October-December) board.

We have submitted a series of patches: https://github.com/SemanticMediaWiki/SemanticMediaWiki/pulls?q=is%3Apr+author%3AAbijeet to help get SMW working with MW master. We have now been running SMW master with MW master for a few weeks.

Since we are running MW on master, we expect issues to still appear in the future, but the major migration of SMW to 1.38 is done.

daniel closed subtask T295883: "Allow $wgSettings to be used in LocalSettings.php" breaks SMW as Resolved.Mar 22 2022, 10:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL