Page MenuHomePhabricator

Preserve parameter serialization order
Closed, ResolvedPublic0 Estimated Story Points

Description

In T274545, we accidentally merged a change that probably changed the order of parameter serialization. It was reverted before hitting any production servers. But this was a warning to us, that we have to make sure our sidebar work doesn't result in reordered serialization. This would create "dirty diffs" when using Visual Editor, historically a very sore topic.

  • Write tests that cover current serialization order.
    • When paramOrder given.
    • When paramOrder not given.
    • When parameters are unspecified.
  • Update TemplateData help to clarify the effect of paramOrder on serialization.

Related Objects

StatusSubtypeAssignedTask
OpenNone
ResolvedWMDE-Fisch
ResolvedWMDE-Fisch
ResolvedAndrew-WMDE
ResolvedWMDE-Fisch
ResolvedAndrew-WMDE
ResolvedBUG REPORTawight
OpenNone
OpenNone
ResolvedNone
InvalidNone
Resolvedthiemowmde
ResolvedAndrew-WMDE
ResolvedNone
ResolvedNone
Resolvedthiemowmde
ResolvedAndrew-WMDE
ResolvedWMDE-Fisch
Resolvedthiemowmde
ResolvedECohen_WMDE
OpenNone

Event Timeline

Change 701111 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] [WIP] Tests for parameter serialization order

https://gerrit.wikimedia.org/r/701111

Change 701111 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Tests for parameter serialization order

https://gerrit.wikimedia.org/r/701111

Change 702137 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Fix broken template serialization test setup

https://gerrit.wikimedia.org/r/702137

Change 702137 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix broken template serialization test setup

https://gerrit.wikimedia.org/r/702137

thiemowmde set the point value for this task to 0.Jul 5 2021, 7:44 AM