Page MenuHomePhabricator
Create Task
Maniphest T285472

Remove entityNamespaces settings
Closed, ResolvedPublic
Actions

Description

This will require rewriting/deleting large parts of WikibaseSettings. Also, there are currently some hooks running in relation to this setting that need to be taken into account.

Details

SubjectRepoBranchLines +/-
Clean up last vestiges of entityNamespaces settingmediawiki/extensions/Wikibasemaster+6 -22
Remove WikibaseRepo foreignRepositories settingmediawiki/extensions/Wikibasemaster+131 -511
Stop using legacy entityNamespaces setting in onSetupAfterCache hookmediawiki/extensions/Wikibasewmf/1.37.0-wmf.12+46 -4
Stop using legacy entityNamespaces setting in onSetupAfterCache hookmediawiki/extensions/Wikibasemaster+46 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.Jun 24 2021, 12:48 PM
Michael moved this task from To Do (prioritised from top to bottom) to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Michael claimed this task.Jun 29 2021, 10:28 AM
Michael mentioned this in T285471: Remove repositories and foreignRepositories legacy settings.
Michael moved this task from Stalled/Waiting to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Michael. · View Herald TranscriptJun 29 2021, 10:28 AM
gerritbot added a comment.Jun 30 2021, 1:44 PM

Change 701531 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Wikibase@master] Stop using legacy entityNamespaces setting in onSetupAfterCache hook

https://gerrit.wikimedia.org/r/701531

gerritbot added a project: Patch-For-Review.Jun 30 2021, 1:44 PM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jun 30 2021, 2:15 PM
gerritbot added a comment.Jun 30 2021, 9:53 PM

Change 701531 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop using legacy entityNamespaces setting in onSetupAfterCache hook

https://gerrit.wikimedia.org/r/701531

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jun 30 2021, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 30 2021, 10:10 PM
gerritbot added a comment.Jul 1 2021, 9:05 AM

Change 702400 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Michael Große):

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.12] Stop using legacy entityNamespaces setting in onSetupAfterCache hook

https://gerrit.wikimedia.org/r/702400

gerritbot added a project: Patch-For-Review.Jul 1 2021, 9:05 AM
gerritbot added a comment.Jul 1 2021, 11:47 AM

Change 702400 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.12] Stop using legacy entityNamespaces setting in onSetupAfterCache hook

https://gerrit.wikimedia.org/r/702400

Stashbot added a comment.Jul 1 2021, 11:54 AM

Mentioned in SAL (#wikimedia-operations) [2021-07-01T11:54:02Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.37.0-wmf.12/extensions/Wikibase/: Backport: [[gerrit:702400|Stop using legacy entityNamespaces setting in onSetupAfterCache hook (T285472)]] (duration: 01m 15s)

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.12; 2021-06-28); removed MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jul 1 2021, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 1 2021, 12:10 PM
Michael removed Michael as the assignee of this task.Jul 8 2021, 1:58 PM
Michael moved this task from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lucas_Werkmeister_WMDE claimed this task.Jul 12 2021, 9:49 AM
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lucas_Werkmeister_WMDE subscribed.

Some work-in-progress happened in this change, but I think this actually requires T285471: Remove repositories and foreignRepositories legacy settings to be done first.

Claiming the task for now.

gerritbot added a comment.Jul 12 2021, 4:24 PM

Change 704137 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Michael Große):

[mediawiki/extensions/Wikibase@master] Remove WikibaseRepo foreignRepositories setting

https://gerrit.wikimedia.org/r/704137

gerritbot added a project: Patch-For-Review.Jul 12 2021, 4:24 PM
Lucas_Werkmeister_WMDE mentioned this in T286539: Remove repoNamespaces setting.Jul 13 2021, 9:43 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 13 2021, 2:39 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 16 2021, 9:58 AM
Lucas_Werkmeister_WMDE added a subtask: T286767: Remove foreignRepositories support in WikibaseCirrusSearch.
Lucas_Werkmeister_WMDE closed subtask T286767: Remove foreignRepositories support in WikibaseCirrusSearch as Resolved.Jul 16 2021, 1:24 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 21 2021, 11:30 AM
gerritbot added a comment.Jul 21 2021, 3:40 PM

Change 704137 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove WikibaseRepo foreignRepositories setting

https://gerrit.wikimedia.org/r/704137

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.16; 2021-07-26); removed MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jul 21 2021, 4:00 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 21 2021, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 21 2021, 4:10 PM
gerritbot added a comment.Jul 22 2021, 10:26 AM

Change 706351 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Clean up last vestiges of entityNamespaces setting

https://gerrit.wikimedia.org/r/706351

gerritbot added a project: Patch-For-Review.Jul 22 2021, 10:26 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 22 2021, 10:26 AM
gerritbot added a comment.Jul 26 2021, 7:49 AM

Change 706351 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Clean up last vestiges of entityNamespaces setting

https://gerrit.wikimedia.org/r/706351

Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 26 2021, 9:07 AM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lucas_Werkmeister_WMDE mentioned this in T257262: entitysources: Clean up any remainders of the legacy back/compat config in Wikibase and extensions.Jul 27 2021, 3:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL