Page MenuHomePhabricator
Create Task
Maniphest T285473

Remove changesDatabase legacy setting
Closed, ResolvedPublic
Actions

Description

This should for now always be the main entitysource repoDb

Details

SubjectRepoBranchLines +/-
Remove changesDatabase settingmediawiki/extensions/Wikibasemaster+2 -43
Stop setting 'repo' ChangeNotificationJob parametermediawiki/extensions/Wikibasemaster+0 -13
Remove 'repo' ChangeNotificationJob parametermediawiki/extensions/Wikibasemaster+2 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.Jun 24 2021, 12:48 PM
Michael moved this task from To Do (prioritised from top to bottom) to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Michael moved this task from Test (Verification) to Needs Announcement on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Michael moved this task from Needs Announcement to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore subscribed.Jul 1 2021, 11:01 PM

Hi @Michael
As the current "unstaller" on camp for this week, could I ask for details to be added regarding why this task is in stalled / waiting?
What is it blocked on / waiting for?

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jul 1 2021, 11:15 PM
Michael added a comment.Jul 2 2021, 8:30 AM
In T285473#7191553, @Addshore wrote:

Hi @Michael
As the current "unstaller" on camp for this week, could I ask for details to be added regarding why this task is in stalled / waiting?
What is it blocked on / waiting for?

Removing this setting in the entire stack requires removing it from the legacy parsers, which only makes sense by removing the legacy parsers as a whole.

The more work on this, the more I get the feeling that maybe this task shouldn't have been split vertically by legacy setting, but horizontally by degree of involvement of all the legacy setting being removed. Maybe I'll rewrite these subtasks later today.

Lucas_Werkmeister_WMDE claimed this task.Jul 13 2021, 2:41 PM
Lucas_Werkmeister_WMDE moved this task from Stalled/Waiting to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lucas_Werkmeister_WMDE subscribed.

Yeah, I think the relationship between tasks on Phabricator and changes on Gerrit is pretty fuzzy right now. But the important thing is, we have changes on Gerrit that achieve removals of these settings and pass in CI, so we’re getting there, one way or another. And with the last set of changes, this becomes doable as well, so I’ll pick it up.

Lucas_Werkmeister_WMDE added a comment.Jul 13 2021, 3:06 PM

This is kind of messed up:

  • Repo’s changesDatabase setting defaults to false.
  • We don’t configure it in mediawiki-config, so it’s false in production.
  • dispatchChanges.php takes that setting and creates a JobQueueChangeNotificationSender with it.
  • JobQueueChangeNotificationSender passes the value as the 'repo' param into the ChangeNotification jobs it creates.
  • In ChangeNotificationJob – now in client! – the 'repo' is therefore false, which would usually mean the local database.
  • However, as far as I can tell, the 'repo' parameter isn’t actually used anywhere. Which is good, because by this point it would refer to the client wiki’s database, not the repo one!

If it’s true that this 'repo' job parameter isn’t used, we should just get rid of it completely. However, we need to be careful: repo and client might be on different train versions, so repo still needs to set the job parameter for at least one train after client stops requiring it.

(Meanwhile, client’s own changesDatabase setting is never used at all.)

gerritbot added a comment.Jul 13 2021, 3:35 PM

Change 704356 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove 'repo' ChangeNotificationJob parameter

https://gerrit.wikimedia.org/r/704356

gerritbot added a project: Patch-For-Review.Jul 13 2021, 3:35 PM

Change 704357 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] DNM: Stop setting 'repo' ChangeNotificationJob parameter

https://gerrit.wikimedia.org/r/704357

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 13 2021, 3:35 PM
Lucas_Werkmeister_WMDE added a comment.Jul 13 2021, 3:41 PM

I’ve tested locally that change dispatching still works with both of the above changes.

gerritbot added a comment.Jul 14 2021, 2:53 PM

Change 704356 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove 'repo' ChangeNotificationJob parameter

https://gerrit.wikimedia.org/r/704356

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.15; 2021-07-19).Jul 14 2021, 3:00 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 14 2021, 3:20 PM

Stalled until the above change has been rolled out to all wikis and we’re fairly confident it’ll stay deployed, so probably until 2021-07-26 or so.

Lucas_Werkmeister_WMDE mentioned this in T287242: Remove repoDatabase legacy setting.Jul 23 2021, 11:40 AM
gerritbot added a comment.Jul 26 2021, 9:48 AM

Change 708074 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove changesDatabase setting

https://gerrit.wikimedia.org/r/708074

Lucas_Werkmeister_WMDE moved this task from Stalled/Waiting to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 26 2021, 9:48 AM
gerritbot added a comment.Jul 26 2021, 6:40 PM

Change 704357 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop setting 'repo' ChangeNotificationJob parameter

https://gerrit.wikimedia.org/r/704357

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.16; 2021-07-26); removed MW-1.37-notes (1.37.0-wmf.15; 2021-07-19).Jul 26 2021, 7:00 PM
gerritbot added a comment.Jul 27 2021, 3:12 PM

Change 708074 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove changesDatabase setting

https://gerrit.wikimedia.org/r/708074

Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 27 2021, 3:17 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lucas_Werkmeister_WMDE mentioned this in T257262: entitysources: Clean up any remainders of the legacy back/compat config in Wikibase and extensions.Jul 27 2021, 3:26 PM
ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.17; 2021-08-02); removed MW-1.37-notes (1.37.0-wmf.16; 2021-07-26).Jul 27 2021, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 27 2021, 4:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL