TypeError: Cannot read property 'key' of undefined
Closed, DeclinedPublicPRODUCTION ERROR
Actions

Assigned To

None

Authored By

	bwang
	Jun 24 2021, 3:25 PM

Description

Error

normalized_message

TypeError: Cannot read property 'key' of undefined

exception.trace

at setStatus  <anonymous>:35:65
at Object.setBannerShown  <anonymous>:38:528
at Object.reallyInsertBanner  <anonymous>:27:174
at HTMLDocument.<anonymous>  <anonymous>:28:627

Impact

111 occurrences in past 12 hrs

Notes

Looks like occurrences are coming from ru.wikipedia.org, and started around

Stack trace shows error originating from here
https://gerrit.wikimedia.org/g/mediawiki/extensions/CentralNotice/+/420a5aa86158fcbc43810d142c0bd453f4f72b25/resources/ext.centralNotice.display/state.js#546

Logstash url: https://logstash.wikimedia.org/goto/e008b5edcf03b4cf67d46c8d8210cc11

Event Timeline

bwang created this task.Jun 24 2021, 3:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 24 2021, 3:25 PM

• DStrine added a project: Fundraising-Backlog.Jun 24 2021, 3:34 PM

bwang removed a subscriber: WMDE-Fundraising-Tech.Jun 24 2021, 4:44 PM

• DStrine moved this task from Triage to Unscheduled on the Fundraising-Backlog board.Jul 1 2021, 3:35 PM

Krinkle removed Request URL.Jul 13 2021, 1:03 AM

Krinkle updated the task description. (Show Details)

Krinkle moved this task from Untriaged to June 2021 on the Wikimedia-production-error board.Jul 13 2021, 1:16 AM

Perhaps this was an error in some in-banner JS? There haven't been any more occurrences of it in the past 12 days, and I don't see the CentralNotice code in that path trying to access any property called 'key'.

The stack from setBannerShown() onwards is in built-in CentralNotice code and takes no parameters, so the calls after that should not be able to crash based on banner content scripts, but I agree it's likely that a banner or URL parameter did cause it. Let's close for now until it either becomes significant in frequency, or reproducible, or correlated with a user-facing issue.

@Krinkle thanks!! :)

TypeError: Cannot read property 'key' of undefinedClosed, DeclinedPublicPRODUCTION ERRORActions