Page MenuHomePhabricator

Rewrite "spec" class in the VisualEditor template editor
Closed, ResolvedPublic0 Estimated Story Points

Details

SubjectRepoBranchLines +/-
mediawiki/extensions/VisualEditormaster+16 -4
mediawiki/extensions/VisualEditormaster+3 -3
mediawiki/extensions/VisualEditormaster+3 -1
mediawiki/extensions/VisualEditormaster+15 -15
mediawiki/extensions/VisualEditormaster+31 -52
mediawiki/extensions/VisualEditormaster+14 -6
mediawiki/extensions/VisualEditormaster+38 -1
mediawiki/extensions/VisualEditormaster+43 -31
mediawiki/extensions/VisualEditormaster+28 -18
mediawiki/extensions/VisualEditormaster+14 -1
mediawiki/extensions/VisualEditormaster+3 -3
mediawiki/extensions/VisualEditormaster+5 -6
mediawiki/extensions/VisualEditormaster+27 -24
mediawiki/extensions/VisualEditormaster+5 -8
mediawiki/extensions/VisualEditormaster+11 -15
mediawiki/extensions/VisualEditormaster+8 -8
mediawiki/extensions/VisualEditormaster+184 -0
Show related patches Customize query in gerrit

Event Timeline

Change 701381 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Add new QUnit test for ve.dm.MWTemplateSpecModel

https://gerrit.wikimedia.org/r/701381

Change 701382 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Better name for spec.getParameterName() method

https://gerrit.wikimedia.org/r/701382

Change 701383 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Better name for spec.isParameterKnown() method

https://gerrit.wikimedia.org/r/701383

Change 701386 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Fix getDescription/Sets possibly returning undefined

https://gerrit.wikimedia.org/r/701386

Change 701389 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Simplify spec code dealing with default values

https://gerrit.wikimedia.org/r/701389

Change 701564 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Minor documentation updates in template related classes

https://gerrit.wikimedia.org/r/701564

Change 701381 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Add new QUnit test for ve.dm.MWTemplateSpecModel

https://gerrit.wikimedia.org/r/701381

Change 701382 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Better name for spec.getParameterName() method

https://gerrit.wikimedia.org/r/701382

Change 701878 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Avoid the term "canonical order" in template related docs

https://gerrit.wikimedia.org/r/701878

Change 701383 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Better name for spec.isParameterKnown() method

https://gerrit.wikimedia.org/r/701383

Change 701386 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix getDescription/Sets possibly returning undefined

https://gerrit.wikimedia.org/r/701386

Change 701886 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Use and document the term "known parameter" in template code

https://gerrit.wikimedia.org/r/701886

Change 701389 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Simplify spec code dealing with default values

https://gerrit.wikimedia.org/r/701389

Change 701564 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Minor documentation updates in template related classes

https://gerrit.wikimedia.org/r/701564

Change 702067 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] [WIP] Track seen parameter names in separate data structure

https://gerrit.wikimedia.org/r/702067

Change 702329 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Fix spec.fillFromTemplate() not skipping aliases any more

https://gerrit.wikimedia.org/r/702329

Change 702333 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Rename temporary "x" variable in spec class tests

https://gerrit.wikimedia.org/r/702333

Change 702333 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Rename temporary "x" variable in spec class tests

https://gerrit.wikimedia.org/r/702333

Change 702329 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix spec.fillFromTemplate() not skipping aliases any more

https://gerrit.wikimedia.org/r/702329

Change 701878 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Avoid the term "canonical order" in template related docs

https://gerrit.wikimedia.org/r/701878

Change 702595 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Add more edge-case test cases for template spec class

https://gerrit.wikimedia.org/r/702595

Change 702596 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Track seen parameter names in separate data structure

https://gerrit.wikimedia.org/r/702596

Change 702597 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Store TemplateData JSON as is instead of copying values

https://gerrit.wikimedia.org/r/702597

Change 702598 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Rename misleading "extend" method in template spec class

https://gerrit.wikimedia.org/r/702598

Change 701886 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Use and document the term "known parameter" in template code

https://gerrit.wikimedia.org/r/701886

Change 702595 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Add more edge-case test cases for template spec class

https://gerrit.wikimedia.org/r/702595

Change 702596 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Track seen parameter names in separate data structure

https://gerrit.wikimedia.org/r/702596

Change 702980 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Keep template parameter position when resolving aliases

https://gerrit.wikimedia.org/r/702980

Change 702981 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Add missing fail-safe to MWTemplateSpecModel.extend()

https://gerrit.wikimedia.org/r/702981

Change 702597 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Store TemplateData JSON as is instead of copying values

https://gerrit.wikimedia.org/r/702597

Change 702598 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Rename misleading "extend" method in template spec class

https://gerrit.wikimedia.org/r/702598

Change 702981 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Add missing fail-safe to MWTemplateSpecModel.extend()

https://gerrit.wikimedia.org/r/702981

thiemowmde set the point value for this task to 0.Jul 5 2021, 7:44 AM

Change 702067 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Minor code cleanups to the MWTemplateSpecModel class

https://gerrit.wikimedia.org/r/702067

Change 702980 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Keep template parameter position when resolving aliases

https://gerrit.wikimedia.org/r/702980