Vector
Closed, InvalidPublicBUG REPORT
Actions

Assigned To

None

Authored By

	Noloader
	Jun 24 2021, 5:47 PM

Description

We run a Mediawiki installation on Ubuntu Server 20.04 x86_64. The server is fully patched. We upgrade from Mediawiki 1.36 to Mediawiki 1.36.1 today.

It looks like the Vector skin no longer works as expected. It was working fine until we upgraded today. After restarting the server we get this infamous warning:

Deprecated: Use of BaseTemplate::getFooterIcons was deprecated in MediaWiki 1.35. [Called from VectorTemplate::getFooterData in /var/www/html/w/skins/Vector/includes/VectorTemplate.php at line 223] in /var/www/html/w/includes/debug/MWDebug.php on line 376

It looks like the warning breaks the CSS. Previously skins that witnessed the warning just printed the warning but applied the skin's formatting. Now it does not apply the formatting.

The browser were are seeing the issue under is Firefox 89.0.1 (64-bit).

I also question the wisdom of running debug code in production. We don't run debug developer gear on our server. All this developer debug code does is increase attack surface and cause problems. Mediawiki should consider removing it from release or production code that is released to the world.

Related Objects

Mentioned Here: rSVECb1b2849488b0: Merge "Adjust floating override" into REL1_36

Event Timeline

Noloader created this task.Jun 24 2021, 5:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 24 2021, 5:47 PM

Mainframe98 added a project: Vector (legacy skin).Jun 24 2021, 5:51 PM

Commit b1b2849 fixed it, thanks.

Updating skin Vector
Entering /var/www/html/w/skins/Vector
remote: Enumerating objects: 18, done.
remote: Counting objects: 100% (14/14), done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 8 (delta 5), reused 8 (delta 5), pack-reused 0
Unpacking objects: 100% (8/8), 934 bytes | 467.00 KiB/s, done.
From https://github.com/wikimedia/mediawiki-skins-Vector
   b82ecc2..170a4eb  master     -> origin/master
HEAD is now at b1b2849 Merge "Adjust floating override" into REL1_36
Branch REL1_36

When I use the 1.36 version of Vector with MediaWiki core 1.36 I do not get this error.

I also question the wisdom of running debug code in production.

This is not debugging code, these are warnings/errors that require action (in this case an upgrade to Vector). You can suppress them in the browser by setting up a log file.
https://www.mediawiki.org/wiki/Manual:How_to_debug#Logging

Also might want to check your settings in LocalSettings.php for the following:

error_reporting( 0 );
ini_set( 'display_errors', 0 );

Use of BaseTemplate::getFooterIcons was deprecated ... in /var/www/html/w/skins/VectorClosed, InvalidPublicBUG REPORTActions

Description

Related Objects

Event Timeline

Use of BaseTemplate::getFooterIcons was deprecated ... in /var/www/html/w/skins/Vector
Closed, InvalidPublicBUG REPORT
Actions