Page MenuHomePhabricator

"New contribution" heading cut off by help link
Open, Needs TriagePublicBUG REPORT

Description

List of steps to reproduce:

What happens?:

The bottom border of the "New contribution" heading is unexpectedly cut off by the help link in the top-right corner.

Screenshot 2021-06-27 at 18.17.56.png (602×1 px, 45 KB)

This problem appears to be specific to the insert by ContentTranslation, since the same page without CX, or any other special page, does not suffer from this problem.

What should have happened instead?:

Screenshot 2021-06-27 at 18.18.07.png (408×1 px, 32 KB)

Other notes:

The normal firstHeading avoids this problem with overflow: visible; so perhaps that's needed here as well.

I also notice another oddity, which is that CX is wrapping two block-level elemenst (h1 and button group) inside an span inline element. Perhaps this span is there by accident?

<div id="content" class="mw-body" role="main">

  <div class="mw-indicators">
    <div id="mw-indicator-mw-helplink" class="mw-indicator"></div>
  </div>

  <span>
    <h1>New contribution</h1>
    <span class="cx-contributions oo-ui-widget oo-ui-widget-enabled oo-ui-buttonGroupWidget"></span>
  </span>

  <h1 id="firstHeading" class="firstHeading" dir="ltr" lang="en">User contributions for Krinkle</h1>

  <div id="bodyContent" class="vector-body"></div>
</div>

Event Timeline

The "new contribution" area is something we may wan to rethink, so it may not be worth spending much time tweaking the current implementation. More context below.

Content Translation expands the Contributions page with options to create a new contribution. That was an initial attempt to create a general area for users to find ways to contribute (as oppose to create a one-off solution for Content Translation).

Recently we started to support translation on mobile, and we proposed a similar entry point (T286466). This is proposed as a more general entry point where different extensions can add to it (and there has been interest from other teams to do so). If this goes well, I think it makes sense to consider a consistent solution for desktop too (reading from the same list of contribution options, following a similar style, etc.), that may replace the "New contribution" section.

With all that. I'd consider to discard the ticket unless anyone else thinks that the effort for this fix is worth it even for a potentially temporary period.

matmarex subscribed.

The "New contribution" heading doesn't seem to exist any more.

Oh… it does exist. But for whatever reason, I don't see it at https://nl.wikipedia.org/wiki/Special:MyContributions, but I do see it at https://en.wikipedia.org/wiki/Special:MyContributions.

The issue is still present on old Vector:

image.png (2×3 px, 828 KB)

But not on new Vector:
image.png (2×3 px, 797 KB)

I guess this task might still be declined based on @Pginer-WMF's previous comments here, but I'll let you close it yourself :)