Page MenuHomePhabricator

Horizontal rule on SpecialRecentChanges[Linked] should not cut across legend box
Closed, ResolvedPublic

Description

It unnecessary gives appearance of divvying up the legend box

Special:RecentChangesSpecial:Watchlist
Screen Shot 2021-06-27 at 8.36.14 PM.png (544×1 px, 209 KB)
Screen Shot 2021-06-27 at 8.43.20 PM.png (434×1 px, 125 KB)

Special:Watchlist has almost similar appearance and does not contains such horizontal rule

Repro:

  1. Go to https://www.mediawiki.org/wiki/Special:Preferences#mw-prefsection-rc
  2. Check "Use non-JavaScript interface"
  3. Go to https://www.mediawiki.org/wiki/Special:RecentChanges

Event Timeline

Ammarpad renamed this task from Horizontal rule on SpecialRecentChanges should not cut across legend box to Horizontal rule on SpecialRecentChanges[Linked] should not cut across legend box.Jun 27 2021, 7:49 PM
Tgr triaged this task as Low priority.Jun 29 2021, 11:52 AM
Tgr moved this task from Inbox to Triaged on the Growth-Team board.
Tgr added a project: good first task.
Tgr added a subscriber: Tgr.

Thanks for reporting!

The legend box probably needs to have a white background. Could be a good first task for someone who is learning MediaWiki development.

Are you using some non-default settings? The layout of the page is different on my end.

image.png (1×2 px, 343 KB)

Even when I turn off Javascript to make it look more like the screenshot, the legend doesn't clip the filter options.
Screen Shot 2021-06-29 at 12.02.02 PM.png (1×2 px, 454 KB)

Even when I turn off Javascript to make it look more like the screenshot, the legend doesn't clip the filter options.

Yea... @Ammarpad what browser are you using? Anything special about your skin or CSS?

I use the non-cluttered interface by checking the "Use non-JavaScript interface" preference. I have added reproduction steps

I use the non-cluttered interface by checking the "Use non-JavaScript interface" preference. I have added reproduction steps

Thank you!

Using the instructions provided, I can confirm the issue with Chrome (Chromium 91.0.4472.114 on Ubuntu). Seems to work fine in Firefox (89.0.1 on Ubuntu).

Using the instructions provided, I can confirm the issue with Chrome (Chromium 91.0.4472.114 on Ubuntu). Seems to work fine in Firefox (89.0.1 on Ubuntu).

Of course it's browser-spefic. can't be a true css issue if it wasn't :)
Definitely the easiest thing to do is what @Tgr said. I'll push out a quick patch.

Change 702378 had a related patch set uploaded (by TChin; author: TChin):

[mediawiki/core@master] Added background color to mw-changeslist-legend

https://gerrit.wikimedia.org/r/702378

Change 702378 merged by jenkins-bot:

[mediawiki/core@master] Added background color to mw-changeslist-legend

https://gerrit.wikimedia.org/r/702378