Page MenuHomePhabricator

Remove Content::getSecondaryDataUpdates
Closed, ResolvedPublic

Description

Method Content::getSecondaryDataUpdates was deprecates since 1.32 and moved to ContentHandler::getSecondaryDataUpdates

However, 2 deployed extensions still override this method. The extensions should start overriding ContentHandler method.

  • Gadgets
  • Newsletter

After that's done, all usages of the method should be removed. Flow is the only extension that uses it in strange way, but instead we could probably just construct a new LinksUpdate there, just copy the contents of the AbstractContent::getSecondaryDataUpdates

Usage in core DerivedPageGataUpdater can be safely removed at this point.

'SecondaryDataUpdates' hook can be removed, it's deprecated since 1.32

Event Timeline

Change 704796 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/Gadgets@master] Override ContentHandler::getDeletionUpdates and ContentHandler::getSecondaryDataUpdates.

https://gerrit.wikimedia.org/r/704796

Change 704938 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/Newsletter@master] Override ContentHandler::getSecondaryDataUpdates.

https://gerrit.wikimedia.org/r/704938

Change 704959 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/Flow@master] Remove Content::getSecondaryDataUpdates just construct a new LinksUpdate there.

https://gerrit.wikimedia.org/r/704959

Change 704796 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Override ContentHandler::getDeletionUpdates and ContentHandler::getSecondaryDataUpdates.

https://gerrit.wikimedia.org/r/704796

Change 704938 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@master] Override ContentHandler::getSecondaryDataUpdates.

https://gerrit.wikimedia.org/r/704938

Change 705868 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/Wikibase@master] Remove useless tests EntityContentTestCase::testGetDeletionUpdates & EntityContentTestCase::testGetSecondaryDataUpdates.

https://gerrit.wikimedia.org/r/705868

Change 704959 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Remove Content::getSecondaryDataUpdates and use WikiPage::doSecondaryDataUpdates.

https://gerrit.wikimedia.org/r/704959

Change 705868 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove useless tests EntityContentTestCase::testGetDeletionUpdates & EntityContentTestCase::testGetSecondaryDataUpdates.

https://gerrit.wikimedia.org/r/705868

Change 706338 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/core@master] Remove Content::getSecondaryDataUpdates() and all usage of it.

https://gerrit.wikimedia.org/r/706338

Change 706338 merged by jenkins-bot:

[mediawiki/core@master] Remove Content::getSecondaryDataUpdates() and all usage of it.

https://gerrit.wikimedia.org/r/706338