Page MenuHomePhabricator
Create Task
Maniphest T285729

Remove Content::getSecondaryDataUpdates
Closed, ResolvedPublic
Actions

Description

Method Content::getSecondaryDataUpdates was deprecates since 1.32 and moved to ContentHandler::getSecondaryDataUpdates

However, 2 deployed extensions still override this method. The extensions should start overriding ContentHandler method.

  • Gadgets
  • Newsletter

After that's done, all usages of the method should be removed. Flow is the only extension that uses it in strange way, but instead we could probably just construct a new LinksUpdate there, just copy the contents of the AbstractContent::getSecondaryDataUpdates

Usage in core DerivedPageGataUpdater can be safely removed at this point.

'SecondaryDataUpdates' hook can be removed, it's deprecated since 1.32

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+3 -151Remove Content::getSecondaryDataUpdates() and all usage of it.
mediawiki/extensions/Wikibasemaster+0 -25Remove useless tests EntityContentTestCase::testGetDeletionUpdates & EntityContentTestCase::testGetSecondaryDataUpdates.
mediawiki/extensions/Flowmaster+1 -9Remove Content::getSecondaryDataUpdates and use WikiPage::doSecondaryDataUpdates.
mediawiki/extensions/Newslettermaster+29 -27Override ContentHandler::getSecondaryDataUpdates.
mediawiki/extensions/Gadgetsmaster+37 -28Override ContentHandler::getDeletionUpdates and ContentHandler::getSecondaryDataUpdates.
Customize query in gerrit

Related Objects

Event Timeline

Pchelolo created this task.Jun 28 2021, 11:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2021, 11:49 PM
Pchelolo mentioned this in T285730: Remove Content::getDeletionUpdates.Jun 29 2021, 12:02 AM
Pchelolo moved this task from Unsorted pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.
roman-stolar moved this task from PageStore pile to Doing on the Platform Team Workboards (MW Expedition) board.Jul 15 2021, 12:03 PM
gerritbot added a comment.Jul 15 2021, 7:39 PM

Change 704796 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/Gadgets@master] Override ContentHandler::getDeletionUpdates and ContentHandler::getSecondaryDataUpdates.

https://gerrit.wikimedia.org/r/704796

gerritbot added a project: Patch-For-Review.Jul 15 2021, 7:39 PM
gerritbot added a comment.Jul 16 2021, 10:59 AM

Change 704938 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/Newsletter@master] Override ContentHandler::getSecondaryDataUpdates.

https://gerrit.wikimedia.org/r/704938

gerritbot added a comment.Jul 16 2021, 12:46 PM

Change 704959 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/Flow@master] Remove Content::getSecondaryDataUpdates just construct a new LinksUpdate there.

https://gerrit.wikimedia.org/r/704959

gerritbot added a comment.Jul 16 2021, 3:38 PM

Change 704796 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Override ContentHandler::getDeletionUpdates and ContentHandler::getSecondaryDataUpdates.

https://gerrit.wikimedia.org/r/704796

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.15; 2021-07-19).Jul 16 2021, 4:00 PM
Pchelolo mentioned this in T232878: The "SecondaryDataUpdates" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet.Jul 16 2021, 4:07 PM
roman-stolar updated the task description. (Show Details)Jul 19 2021, 11:52 AM
gerritbot added a comment.Jul 19 2021, 2:48 PM

Change 704938 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@master] Override ContentHandler::getSecondaryDataUpdates.

https://gerrit.wikimedia.org/r/704938

roman-stolar updated the task description. (Show Details)Jul 20 2021, 1:45 PM
gerritbot added a comment.Jul 21 2021, 1:36 PM

Change 705868 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/Wikibase@master] Remove useless tests EntityContentTestCase::testGetDeletionUpdates & EntityContentTestCase::testGetSecondaryDataUpdates.

https://gerrit.wikimedia.org/r/705868

gerritbot added a comment.Jul 21 2021, 1:52 PM

Change 704959 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Remove Content::getSecondaryDataUpdates and use WikiPage::doSecondaryDataUpdates.

https://gerrit.wikimedia.org/r/704959

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.16; 2021-07-26); removed MW-1.37-notes (1.37.0-wmf.15; 2021-07-19).Jul 21 2021, 2:00 PM
gerritbot added a comment.Jul 22 2021, 9:25 AM

Change 705868 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove useless tests EntityContentTestCase::testGetDeletionUpdates & EntityContentTestCase::testGetSecondaryDataUpdates.

https://gerrit.wikimedia.org/r/705868

gerritbot added a comment.Jul 22 2021, 9:56 AM

Change 706338 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/core@master] Remove Content::getSecondaryDataUpdates() and all usage of it.

https://gerrit.wikimedia.org/r/706338

Pchelolo moved this task from Doing to On the train on the Platform Team Workboards (MW Expedition) board.Jul 22 2021, 1:45 PM
gerritbot added a comment.Jul 22 2021, 2:18 PM

Change 706338 merged by jenkins-bot:

[mediawiki/core@master] Remove Content::getSecondaryDataUpdates() and all usage of it.

https://gerrit.wikimedia.org/r/706338

Pchelolo closed this task as Resolved.Aug 1 2021, 1:57 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL