Page MenuHomePhabricator

Do not use relative => true until autocomplete bug is fixed
Closed, ResolvedPublic

Description

I filled T285748: 'relative' => true makes autocomplete use the main namespace, regardless what 'namespace' says about a bug in mediawiki's special page systems. Since I currently don't have enough energy to look at it in depth, I think we should remove relative => true from special:Editgrowthconfig, and use namespace prefixes instead.

As soon as the task is fixed, we can revert that workaround.

When you try to add an (existing) template if there's a main space page starting with the same title, it won't be possible. See below:

image.png (168×794 px, 9 KB)

I'm trying to add template called পরিষ্করণ to the form, but that's not possible, because there's an article starting with the same prefix (and due to exists => true, it shows no redlink autocomplete I could use).

(screenshot taken on bnwiki)

Event Timeline

Change 702097 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] SpecialEditGrowthConfig: Do not use relative => true

https://gerrit.wikimedia.org/r/702097

Change 702097 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] SpecialEditGrowthConfig: Do not use relative => true

https://gerrit.wikimedia.org/r/702097

Change 702173 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.11] SpecialEditGrowthConfig: Do not use relative => true

https://gerrit.wikimedia.org/r/702173

Change 702174 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.12] SpecialEditGrowthConfig: Do not use relative => true

https://gerrit.wikimedia.org/r/702174

I'll backport this, as it has user-impact.

Change 702174 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.12] SpecialEditGrowthConfig: Do not use relative => true

https://gerrit.wikimedia.org/r/702174

Change 702173 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.11] SpecialEditGrowthConfig: Do not use relative => true

https://gerrit.wikimedia.org/r/702173

Mentioned in SAL (#wikimedia-operations) [2021-06-29T23:34:50Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.12/extensions/GrowthExperiments/includes/Specials/SpecialEditGrowthConfig.php: c61fb175c82accda526105cc32457b07530d09fa: SpecialEditGrowthConfig: Do not use relative => true (T285750) (duration: 01m 05s)

Mentioned in SAL (#wikimedia-operations) [2021-06-29T23:41:43Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.11/extensions/GrowthExperiments/includes/Specials/SpecialEditGrowthConfig.php: 8a5b835050cc0f6d47b6fde2317db8743fcb9ce0: SpecialEditGrowthConfig: Do not use relative => true (T285750) (duration: 01m 04s)