Page MenuHomePhabricator

Confusing error message when trying to save geoshape / tabular data that doesn’t exist
Closed, ResolvedPublic1 Estimated Story Points

Description

As a Wikidata editor, I want the UI to show me useful and comprehensible error messages when I do something wrong.

Problem:
With the geoshape or tabular data datatypes, if you try to save a value for a data page that doesn’t exist on Commons, you get an error. That error message is broken:

Could not save due to an error.

⧼wikibase-validator-page-not-exist⧽

Example:

Screenshots/mockups:

Screenshot 2021-06-29 at 13-11-42 Wikidata Sandbox.png (158×952 px, 15 KB)

BDD
GIVEN a Data: filename that does not exist on Commons
WHEN I try to add it on some item as a statement for a geoshape or tabular data property
THEN I get a human-readable error message

Acceptance criteria:

  • The error message works.

Notes:

  • The correct error message is “page-not-exists” (wikibase-validator-page-not-exists in repo/i18n/en.json and translations). InterWikiLinkExistsValidator has “page-not-exist”.

Event Timeline

Addshore set the point value for this task to 1.Sep 22 2021, 10:49 AM

Change 725938 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Fix message key in InterWikiLinkExistsValidator

https://gerrit.wikimedia.org/r/725938

Change 725938 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fix message key in InterWikiLinkExistsValidator

https://gerrit.wikimedia.org/r/725938