Page MenuHomePhabricator

Port patches for diff markers to wikidiff2
Closed, ResolvedPublic2 Estimated Story PointsFeature

Description

We need to copy everything that was done at T192526 into wikidiff2. Creating a separate ticket for easier tracking on our board.

Event Timeline

Change 702196 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/php/wikidiff2@master] Move diff markers content to a data attribute

https://gerrit.wikimedia.org/r/702196

Daimona set the point value for this task to 2.Jun 29 2021, 6:21 PM
Daimona added a project: wikidiff2.

Actually, only r651809 needs to be ported. r652191 does nothing relevant for wikidiff2. I also still have to port the part about adding a <br> for empty lines.

Change 702355 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/php/wikidiff2@master] Remove spaces from empty lines and preserve line breaks with <br>

https://gerrit.wikimedia.org/r/702355

Change 702196 merged by jenkins-bot:

[mediawiki/php/wikidiff2@master] Move diff markers content to a data attribute

https://gerrit.wikimedia.org/r/702196

Change 702355 merged by jenkins-bot:

[mediawiki/php/wikidiff2@master] Remove spaces from empty lines and preserve line breaks with <br>

https://gerrit.wikimedia.org/r/702355

It's look maybe wikidiff2 changes won't auto-deploy to the beta cluster. Testing this in your local environment can be quite a struggle, too… so I guess I'll leave this ticket here for now and when a new version of wikidiff2 is cut, we will (if possible) get it deployed to the beta cluster before production.

It's look maybe wikidiff2 changes won't auto-deploy to the beta cluster. Testing this in your local environment can be quite a struggle, too… so I guess I'll leave this ticket here for now and when a new version of wikidiff2 is cut, we will (if possible) get it deployed to the beta cluster before production.

Because it's a PHP extension, wikidiff2 is built and deployed as a Debian package, once a new release is made you'll need to ask SRE to update the package so it can be tested on beta cluster and then rolled out in production.

Daimona changed the task status from Open to Stalled.Aug 18 2021, 11:13 PM

Cannot be tested until T285857 is done for the beta cluster.

Diff 2 is now deployed to beta cluster, therefore this ticket can be closed.

MusikAnimal changed the task status from Stalled to Open.Oct 13 2021, 11:24 PM
NRodriguez subscribed.

For port patching tickets like this one, where the functionality is tested elsewhere, feel free to resolve directly after QA @imaigwilo ! Happy to do it myself too just thought I'd let you know.