Page MenuHomePhabricator
Create Task
Maniphest T285793

Lock selection to a single side in wikidiff2
Closed, ResolvedPublic1 Estimated Story PointsFeature
Actions

Description

Adopt the solution outlined at T285285.

Details

SubjectRepoBranchLines +/-
Add CSS classes for side lock to empty lines, toomediawiki/php/wikidiff2master+102 -102
diff: Add user-select:none to moved paragraph markersmediawiki/coremaster+4 -0
Add CSS classes for locking selection to a single sidemediawiki/php/wikidiff2master+297 -296
Customize query in gerrit

Related Objects
Search...

Event Timeline

Daimona created this task.Jun 29 2021, 6:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2021, 6:38 PM
Daimona added a parent task: T285856: Release new version of wikidiff2 with side-locking selection.Jun 30 2021, 1:01 PM
Daimona edited projects, added Community-Tech (CommTech-Sprint-4); removed Community-Tech (CommTech-Sprint-3).Jun 30 2021, 6:15 PM
Daimona renamed this task from Lock selection to a single side in diffs to Lock selection to a single side in wikidiff2.Jul 1 2021, 2:44 PM
Daimona updated the task description. (Show Details)
Daimona added a project: wikidiff2.

This should happen after TableDiffFormatter is updated, so we can have a round of QA before we go live in prod.

Daimona added a subtask: T285956: Lock selection to a single side in TableDiffFormatter.Jul 1 2021, 2:46 PM
Daimona changed the subtype of this task from "Bug Report" to "Feature Request".Jul 12 2021, 3:20 PM
Daimona changed the task status from Open to Stalled.Jul 12 2021, 3:23 PM

Making it clear that this task is essentially blocked on its subtask, T285956, passing the QA stage.

ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-5); removed Community-Tech (CommTech-Sprint-4).Jul 19 2021, 1:52 PM
Daimona claimed this task.Jul 28 2021, 5:16 PM
HMonroy moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-5) board.Jul 28 2021, 5:17 PM
matmarex subscribed.Jul 29 2021, 12:18 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-6); removed Community-Tech (CommTech-Sprint-5).Aug 2 2021, 6:20 PM
ldelench_wmf moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-6) board.
gerritbot added a comment.Aug 10 2021, 2:01 PM

Change 711136 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/php/wikidiff2@master] Add CSS classes for locking selection to a single side

https://gerrit.wikimedia.org/r/711136

gerritbot added a project: Patch-For-Review.Aug 10 2021, 2:01 PM
Daimona changed the task status from Stalled to Open.Aug 10 2021, 2:01 PM
Daimona set the point value for this task to 1.

QA passed.

Daimona moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-6) board.Aug 10 2021, 2:03 PM
gerritbot added a comment.Aug 10 2021, 3:04 PM

Change 711149 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] diff: Add user-select:none to moved paragraph markers

https://gerrit.wikimedia.org/r/711149

gerritbot added a comment.Aug 10 2021, 6:20 PM

Change 711149 merged by jenkins-bot:

[mediawiki/core@master] diff: Add user-select:none to moved paragraph markers

https://gerrit.wikimedia.org/r/711149

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 10 2021, 7:00 PM
gerritbot added a comment.Aug 10 2021, 11:11 PM

Change 711136 merged by jenkins-bot:

[mediawiki/php/wikidiff2@master] Add CSS classes for locking selection to a single side

https://gerrit.wikimedia.org/r/711136

MusikAnimal moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-6) board.Aug 10 2021, 11:39 PM
MusikAnimal subscribed.

Moving to QA, but as with the other related tasks we won't actually be able to QA until a new release of wikidiff2 is cut and deployed to the beta cluster. I believe T285856 is tracking that.

Maintenance_bot removed a project: Patch-For-Review.Aug 11 2021, 12:10 AM
• NRodriguez closed subtask T285956: Lock selection to a single side in TableDiffFormatter as Resolved.Aug 11 2021, 10:28 PM
gerritbot added a comment.Aug 12 2021, 2:52 PM

Change 712367 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/php/wikidiff2@master] Apply side lock to diff headers and empty lines, too

https://gerrit.wikimedia.org/r/712367

gerritbot added a project: Patch-For-Review.Aug 12 2021, 2:52 PM
Daimona moved this task from QA 🐛 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-6) board.Aug 12 2021, 2:52 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-7); removed Community-Tech (CommTech-Sprint-6).Aug 16 2021, 1:52 PM
ldelench_wmf moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-7) board.
gerritbot added a comment.Aug 18 2021, 9:44 AM

Change 712367 merged by jenkins-bot:

[mediawiki/php/wikidiff2@master] Add CSS classes for side lock to empty lines, too

https://gerrit.wikimedia.org/r/712367

awight subscribed.Aug 18 2021, 9:49 AM

This is great to see! Probably still needs side lock classes added to the diff headers as well.

Maintenance_bot removed a project: Patch-For-Review.Aug 18 2021, 10:10 AM
Daimona moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-7) board.Aug 18 2021, 2:31 PM
Daimona changed the task status from Open to Stalled.Aug 18 2021, 11:13 PM

Cannot be tested until T285857 is done for the beta cluster.

Daimona added a comment.Aug 18 2021, 11:16 PM
In T285793#7290778, @awight wrote:

This is great to see! Probably still needs side lock classes added to the diff headers as well.

I think the headers are only generated in core, not wikidiff2. T288676 should have fixed that.

ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-8); removed Community-Tech (CommTech-Sprint-7).Aug 30 2021, 8:45 PM
ldelench_wmf moved this task from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-8) board.
dom_walden mentioned this in T290731: Support diffs copy and paste for RTL languages.Sep 10 2021, 12:53 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-9); removed Community-Tech (CommTech-Sprint-8).Sep 13 2021, 7:37 PM
ldelench_wmf moved this task from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-9) board.
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-10); removed Community-Tech (CommTech-Sprint-9).Sep 27 2021, 8:32 PM
ldelench_wmf moved this task from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-10) board.
Daimona mentioned this in T285857: Deploy wikidiff2 1.13.0.Sep 30 2021, 12:46 PM
dom_walden mentioned this in T292207: Issues dragging and dropping text on diff pages on Chrome.Sep 30 2021, 3:25 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-11); removed Community-Tech (CommTech-Sprint-10).Oct 11 2021, 1:48 PM
ldelench_wmf moved this task from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-11) board.
Daimona changed the task status from Stalled to Open.Oct 15 2021, 12:13 PM
• imaigwilo subscribed.Oct 18 2021, 10:03 PM

Verified user can select text from just one column rather than having to copy both columns.
Tested on Safari, Firefox, IE, Chrome, Edge, and Opera

• imaigwilo moved this task from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Sprint-11) board.Oct 18 2021, 10:04 PM
• NRodriguez closed this task as Resolved.Oct 20 2021, 7:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL